Drawable com.example.app:drawable/mr_button_dark_static [261878418]

Fixed

Bug

Status Update

No update yet.

Description

bo...@justin.tv

created issue #1

Dec 8, 2022 08:17PM

Component used: androidx.mediarouter Version used: 1.3.1 Devices/Android versions reproduced on:

When reporting bugs, please always include:

We see the following stack trace in Crashlytics, but we can't reproduce the problem locally.

mr_button_dark_static.xml refers to ic_mr_button_connected_30_dark, ic_mr_button_disconnected_dark, and ic_mr_button_disabled_dark.

ic_mr_button_disconnected_dark and ic_mr_button_disabled_dark both have xxhdpi, xhdpi, hdpi, and mdpi versions, but ic_mr_button_connected_30_dark only has xxhdpi and xhdpi versions, so maybe this is the problem?

Fatal Exception: java.lang.RuntimeException: An error occurred while executing doInBackground()
       at android.os.AsyncTask$4.done(AsyncTask.java:415)
       at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
       at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
       at java.util.concurrent.FutureTask.run(FutureTask.java:271)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)
Caused by android.content.res.Resources$NotFoundException: Drawable com.example.app:drawable/mr_button_dark_static with resource ID #0x7f08048b
Caused by android.content.res.Resources$NotFoundException: File res/drawable/mr_button_dark_static.xml from drawable resource ID #0x7f08048b
       at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:874)
       at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:668)
       at android.content.res.Resources.loadDrawable(Resources.java:993)
       at android.content.res.Resources.getDrawableForDensity(Resources.java:983)
       at android.content.res.Resources.getDrawable(Resources.java:922)
       at android.content.Context.getDrawable(Context.java:754)
       at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
       at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
       at androidx.appcompat.content.res.AppCompatResources.getDrawable(AppCompatResources.java:66)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:869)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:856)
       at android.os.AsyncTask$3.call(AsyncTask.java:394)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)
Caused by org.xmlpull.v1.XmlPullParserException: Binary XML file line #4: <item> tag requires a 'drawable' attribute or child tag defining a drawable
       at android.graphics.drawable.StateListDrawable.inflateChildElements(StateListDrawable.java:195)
       at android.graphics.drawable.StateListDrawable.inflate(StateListDrawable.java:126)
       at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:145)
       at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1399)
       at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1358)
       at android.content.res.ResourcesImpl.loadXmlDrawable(ResourcesImpl.java:906)
       at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:860)
       at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:668)
       at android.content.res.Resources.loadDrawable(Resources.java:993)
       at android.content.res.Resources.getDrawableForDensity(Resources.java:983)
       at android.content.res.Resources.getDrawable(Resources.java:922)
       at android.content.Context.getDrawable(Context.java:754)
       at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
       at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
       at androidx.appcompat.content.res.AppCompatResources.getDrawable(AppCompatResources.java:66)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:869)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:856)
       at android.os.AsyncTask$3.call(AsyncTask.java:394)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)

Comments

ja...@gmail.com <ja...@gmail.com> #2Apr 7, 2023 06:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3582a85010eea5f6676c7ab596e5f019b4ec794f
Author: Ian Lake <ilake@google.com>
Date: Thu Nov 15 13:20:39 2018

Expand ActivityNavigator.Extras for passing flags

Instead of just being able to pass an instance
of ActivityOptionsCompat, move ActivityNavigator.Extras
to a Builder pattern and add the ability to add
any set of Intent.FLAG_ACTIVITY_ flags at runtime.

Test: updated tests
BUG: 119628354
Change-Id: If58c80ac4eafd630cb982762ea7fa802dd16ec92

M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/ktx/build.gradle
A navigation/runtime/ktx/src/androidTest/java/androidx/navigation/ActivityNavigatorExtrasTest.kt
A navigation/runtime/ktx/src/main/java/androidx/navigation/ActivityNavigatorExtras.kt
M navigation/runtime/src/androidTest/java/androidx/navigation/ActivityNavigatorTest.kt
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java

https://android-review.googlesource.com/828140

https://goto.google.com/android-sha1/3582a85010eea5f6676c7ab596e5f019b4ec794f

vi...@eitv.com.br <vi...@eitv.com.br> #3Sep 29, 2023 06:04PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a62e0621853c18be1d07cc8fba078d92a424e24a
Author: Ian Lake <ilake@google.com>
Date: Thu Nov 15 13:50:59 2018

Remove deprecated clearTask and launchDocument flags

Test: remaining tests still pass
BUG: 119628354
Change-Id: Ic411df16dd3a21351bbd7bac367ed98f9e66025a

M navigation/common/ktx/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
M navigation/common/ktx/src/main/java/androidx/navigation/NavOptionsBuilder.kt
M navigation/common/src/main/java/androidx/navigation/NavOptions.java
M navigation/common/src/main/res/values/attrs.xml
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java

https://android-review.googlesource.com/828160

https://goto.google.com/android-sha1/a62e0621853c18be1d07cc8fba078d92a424e24a

ti...@candyspace.com <ti...@candyspace.com> #4Oct 4, 2023 10:10AM

If the app:clearTask is removed, how can i do when i have a splash and guide page ?
The first page is splash and wen enter the main page, the splash should be removed,or when back from the main,it will go to splash page,that is total wrong.

aq...@google.com <aq...@google.com> #5Oct 27, 2023 10:31AM

popUpTo will be able to do that:

https://stackoverflow.com/questions/50336112/how-to-disable-up-in-navigation-for-some-fragment-with-the-new-navigation-archit

bo...@justin.tv <bo...@justin.tv> #6Oct 27, 2023 04:04PM

At current now，there is two ways to do the above。

One：
In the NavHostFragment's Activity, override the onBackPress() method,adn if the current NavDestination is MainFragment then just finish the Activity.

@Override
public void onBackPressed() {
NavDestination navDestination = mNavController.getCurrentDestination();
if (navDestination != null
&& navDestination.getId() == R.id.mainFragment) {
finish();
return;
}
super.onBackPressed();
}

Two:
Set the to MainFragment action in Navigation_graph app:popUpTo="@id/nav_graph" and app:popUpToInclusive="true"

<?xml version="1.0" encoding="utf-8"?>
<navigation
android:id="@+id/nav_graph"
xmlns:android="

http://schemas.android.com/apk/res/android"
xmlns:app="

http://schemas.android.com/apk/res-auto"
xmlns:tools="

http://schemas.android.com/tools"
app:startDestination="@id/splashFragment">

<fragment
android:id="@+id/splashFragment"
android:name="com.ihuman.storydemo.fragment.splash.SplashFragment"
android:label="fragment_splash"
tools:layout="@layout/fragment_splash">
<action
android:id="@+id/action_splashFragment_to_mainFragment"
app:destination="@id/mainFragment"
app:enterAnim="@anim/anim_right_in"
app:exitAnim="@anim/anim_left_out"
app:popEnterAnim="@anim/anim_left_in"
app:popExitAnim="@anim/anim_right_out"
app:popUpTo="@id/nav_graph"
app:popUpToInclusive="true"/>
<action
android:id="@+id/action_splashFragment_to_guideFragment"
app:destination="@id/guideFragment"
app:enterAnim="@anim/anim_right_in"
app:exitAnim="@anim/anim_left_out"
app:popEnterAnim="@anim/anim_left_in"
app:popExitAnim="@anim/anim_right_out"
app:popUpTo="@id/nav_graph"
app:popUpToInclusive="true"/>
</fragment>

<fragment
android:id="@+id/guideFragment"
android:name="com.ihuman.storydemo.fragment.guide.GuideFragment"
android:label="GuideFragment"
tools:layout="@layout/fragment_guide">
<action
android:id="@+id/action_guideFragment_to_mainFragment"
app:destination="@id/mainFragment"
app:enterAnim="@anim/anim_right_in"
app:exitAnim="@anim/anim_left_out"
app:popEnterAnim="@anim/anim_left_in"
app:popExitAnim="@anim/anim_right_out"
app:popUpTo="@id/nav_graph"
app:popUpToInclusive="true"/>
</fragment>

<fragment
android:id="@+id/mainFragment"
android:name="com.ihuman.storydemo.fragment.main.MainFragment"
android:label="fragment_main"
tools:layout="@layout/fragment_main">

</fragment>

</navigation>

Wish for help!

aq...@google.com <aq...@google.com> #7Oct 30, 2023 04:29PM

Reassigned to aq...@google.com.

Ah, apologies. I was sure we had fixed that some time ago, but the change was not merged, as far as I can tell. Thanks for pointing that out again. I'll look into this.

ap...@google.com <ap...@google.com> #8Nov 1, 2023 05:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit cddba9334fdcdc5e5e7ac6df9753df7095545814
Author: Santiago Seifert <aquilescanta@google.com>
Date: Wed Nov 01 16:35:29 2023

Add missing dpi versions for ic_mr_button_connected_30_dark

Add hdpi and mdpi versions of ic_mr_button_connected_30_dark,
which are missing when compared to other drawables like
ic_mr_button_disconnected_dark and ic_mr_button_disabled_dark.

Bug: 261878418
Test: Manually using an emulator with hdpi resolution and the routing demo app.
Change-Id: I907c0581d186d5c7b58e092cda645fb1994f0757

A mediarouter/mediarouter/src/main/res/drawable-hdpi/ic_mr_button_connected_30_dark.png
A mediarouter/mediarouter/src/main/res/drawable-mdpi/ic_mr_button_connected_30_dark.png

https://android-review.googlesource.com/2812744

aq...@google.com <aq...@google.com> #9Nov 1, 2023 05:50PM

Marked as fixed.

The two missing resolutions have been added in https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2812744. Next steps are:

Let me know if I missed anything.
Please upgrade to the next release that includes the fix.
File a fresh bug if the issue still reproduced, but please provide more info about the patterns behind the crash, like affected API versions, affected device models and DPI.