Fixed
Status Update
Comments
ja...@gmail.com <ja...@gmail.com> #2
what is in update.zip ? can you share that file to triage this issue
vi...@eitv.com.br <vi...@eitv.com.br> #3
MHC19Q for Nexus 5X (bullhead) - https://dl.google.com/dl/android/aosp//bullhead-ota-mhc19q-8fe67a2b.zip
N4F26T for Nexus 5X (bullhead) -https://dl.google.com/dl/android/aosp/bullhead-ota-n4f26t-648ce802.zip
WW-12.2.5.23 for Asus ZenFone Go (ASUS_X014D) -http://dlcdnet.asus.com/pub/ASUS/ZenFone/ZB452KG/UL-ASUS_X014D-WW-12.2.5.23-user.zip
Look like, this happens only with a big images.
N4F26T for Nexus 5X (bullhead) -
WW-12.2.5.23 for Asus ZenFone Go (ASUS_X014D) -
Look like, this happens only with a big images.
ti...@candyspace.com <ti...@candyspace.com> #4
On Windows 10 (x64)
aq...@google.com <aq...@google.com> #5
related to (and probably worked around for now by) internal bug http://b/36046324
i do think we should also start shipping a 64-bit Windows platform tools package.
we should also consider changing android::base::ReadFdToString to call fstat and pre-size the vector. not worthwhile for reading things like /proc/uptime, but the default expansion behavior for a huge file like a full OTA update is going to result in substantial overhead. (which will explain the regression between .3 and .4, since the former will have allocated exactly the necessary number of bytes.)
lastly (and maybe not worth doing at all, depending on how soon we can get folks to use a 64-bit platform tools on Windows, since all the other platforms are already 64-bit-only), we could consider rewriting the adb sideload code to (a) mmap/munmap rather than actually read in to physical memory or (b) pread. i'm not sure what the performance impact of pread would be (especially on Windows where there is no pread equivalent).
i do think we should also start shipping a 64-bit Windows platform tools package.
we should also consider changing android::base::ReadFdToString to call fstat and pre-size the vector. not worthwhile for reading things like /proc/uptime, but the default expansion behavior for a huge file like a full OTA update is going to result in substantial overhead. (which will explain the regression between .3 and .4, since the former will have allocated exactly the necessary number of bytes.)
lastly (and maybe not worth doing at all, depending on how soon we can get folks to use a 64-bit platform tools on Windows, since all the other platforms are already 64-bit-only), we could consider rewriting the adb sideload code to (a) mmap/munmap rather than actually read in to physical memory or (b) pread. i'm not sure what the performance impact of pread would be (especially on Windows where there is no pread equivalent).
bo...@justin.tv <bo...@justin.tv> #6
Correction to #5: Windows does support pread() - it's in ReadFile()'s OVERLAPPED parameter.
aq...@google.com <aq...@google.com> #7
@7: we'd still need to write the pread wrapper, though. (similar if we went with mmap/munmap.)
https://android-review.googlesource.com/#/c/355481/ pre-sizes the vector, which should be enough to undo the regression from '.3 to '.4...
ap...@google.com <ap...@google.com> #8
aq...@google.com <aq...@google.com> #9
Hi I'm getting the same issue on Windows 10 when I try to sideload a TWRP backup.
- adb devices gives my device
- adb usb gives error: closed
- adb sideload 6.13.771.4_ckpv5.zip gives
loading: '6.13.771.4_ckpv5.zip'...
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Please can somebody help with this issue I've been trying to sort this for 3 days. Thanks.
- adb devices gives my device
- adb usb gives error: closed
- adb sideload 6.13.771.4_ckpv5.zip gives
loading: '6.13.771.4_ckpv5.zip'...
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Please can somebody help with this issue I've been trying to sort this for 3 days. Thanks.
Description
Component used: androidx.mediarouter Version used: 1.3.1 Devices/Android versions reproduced on:
When reporting bugs, please always include:
We see the following stack trace in Crashlytics, but we can't reproduce the problem locally.
mr_button_dark_static.xml
refers toic_mr_button_connected_30_dark
,ic_mr_button_disconnected_dark
, andic_mr_button_disabled_dark
.ic_mr_button_disconnected_dark
andic_mr_button_disabled_dark
both havexxhdpi
,xhdpi
,hdpi
, andmdpi
versions, butic_mr_button_connected_30_dark
only hasxxhdpi
andxhdpi
versions, so maybe this is the problem?