ImmersiveList "focusableItem" not compatible with "clickable" [263061052]

Fixed

Bug

Status Update

No update yet.

Description

re...@gmail.com

created issue #1

Dec 19, 2022 04:58PM

Component used: TV

Version used: 1.0.0-alpha03

Devices/Android versions reproduced on: Emulator (Android TV 4K API 33)

This is pretty simple to reproduce. For items within an immersive list, the focusableItem modifier should be applied to each list item in which the background should change. If focusableItem is used with clickable clickable no longer works.

I think passing an InteractionSource to focusableItem which is also shared with clickable will resolve the issue.

    val interactionSource = remember { MutableInteractionSource() }
    Box( 
        modifier = Modifier
            .onFocusChanged { focusState ->
                if (focusState.isFocused) {
                    background = Color.White
                    textColor = Color.Black
                } else {
                    background = originalColor
                    textColor = Color.White
                }
            }
            .focusableItem(index) // Note interactionSource is not available here.
            .clickable(
                onClick = onClick,
                interactionSource = interactionSource,
                indication = rememberRipple()
            )
            .size(100.dp)
            .background(
                color = background
            ), contentAlignment = Alignment.Center
    ) {
        Text(text = index.toString(), color = textColor)
    }

Comments

rv...@google.com <rv...@google.com> Dec 20, 2022 08:19AM

Reassigned to rv...@google.com.

rv...@google.com <rv...@google.com> Dec 20, 2022 12:50PM

Accepted by rv...@google.com.

rv...@google.com <rv...@google.com> #2Dec 21, 2022 11:46AM

Thanks for reporting this. We will investigate this and get back to you once we have an update.

ap...@google.com <ap...@google.com> #3Jan 12, 2023 02:25AM

Project: platform/frameworks/support
Branch: androidx-main

commit 5dd50789a7bbcba846f41e4265bd5411fb542b02
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Wed Dec 21 17:16:55 2022

Fixed "clickable" modifier doesn't work with ImmersiveList

* In the "focusableItem" modifier, we add a "focusable" modifier. Now, if the user adds the "clickable" modifier, the
"focusable" modifier added by us has no effect. So, we are now removing the "focusable" modifier
from it. Now, user will have to manually add "focusable()" or "clickable()" along with
"focusableItem". Since this is an immersive list item, ideally, the item will always be clickable.

* Renamed "focusableItem" modifier to "immersiveListItem" modifier which is a better name for the new API and also this
makes it clear, while reading, that this modifier is only part of "ImmersiveList" and also makes
doesn't hint that "focusable()" modifier would be auto-applied

* Moved the immersive list component out of the sub-package

* Added missing ktdocs for params

* Added sample immersive list usage

Bug:

b/263061052

Test: Updated tests

Relnote: "Renamed `focusableItem` to `immersiveListItem` and removed `focusable()` modifier. Now
users will have to manually add `focusable()` or `clickable()` modifier along with
`immersiveListItem`"

Change-Id: I1fd6c8cca3d7f4e810ad838ec1aad0b3c3e41450

M tv/integration-tests/demos/src/main/java/androidx/tv/integration/demos/ImmersiveList.kt
A tv/samples/src/main/java/androidx/tv/samples/ImmersiveListSamples.kt
M tv/tv-material/api/current.txt
M tv/tv-material/api/public_plus_experimental_current.txt
M tv/tv-material/api/restricted_current.txt
M tv/tv-material/src/androidTest/java/androidx/tv/material/ImmersiveListTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/ImmersiveList.kt

https://android-review.googlesource.com/2363328

rv...@google.com <rv...@google.com> #4Jan 12, 2023 02:28AM

Marked as fixed.

The issue has been fixed and merged to Android Open Source Project. The fix should be available in the next tv-compose release (Version: 1.0.0-alpha04).

Closing this ticket. Feel free to re-open in case of any issues.

Thanks 😀

pr...@google.com <pr...@google.com> #5Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

Issue 263061052