ImmersiveList "focusableItem" not compatible with "clickable" [263061052]

Fixed

Bug

Status Update

No update yet.

Description

re...@gmail.com

created issue #1

Dec 19, 2022 04:58PM

Component used: TV

Version used: 1.0.0-alpha03

Devices/Android versions reproduced on: Emulator (Android TV 4K API 33)

This is pretty simple to reproduce. For items within an immersive list, the focusableItem modifier should be applied to each list item in which the background should change. If focusableItem is used with clickable clickable no longer works.

I think passing an InteractionSource to focusableItem which is also shared with clickable will resolve the issue.

    val interactionSource = remember { MutableInteractionSource() }
    Box( 
        modifier = Modifier
            .onFocusChanged { focusState ->
                if (focusState.isFocused) {
                    background = Color.White
                    textColor = Color.Black
                } else {
                    background = originalColor
                    textColor = Color.White
                }
            }
            .focusableItem(index) // Note interactionSource is not available here.
            .clickable(
                onClick = onClick,
                interactionSource = interactionSource,
                indication = rememberRipple()
            )
            .size(100.dp)
            .background(
                color = background
            ), contentAlignment = Alignment.Center
    ) {
        Text(text = index.toString(), color = textColor)
    }

Comments

rv...@google.com <rv...@google.com> Dec 20, 2022 08:19AM

Reassigned to rv...@google.com.

rv...@google.com <rv...@google.com> Dec 20, 2022 12:50PM

Accepted by rv...@google.com.

rv...@google.com <rv...@google.com> #2Dec 21, 2022 11:46AM

What about Enums? Enum is a type-safe way to pass navigation arguments.
Will Enums be covered in this issue as part of Serializable or will have own handled separately?
Because for enum you can provide a reasonable default value but for Parcelable or Serializable only @null

ap...@google.com <ap...@google.com> #3Jan 12, 2023 02:25AM

Please add support for Serializable objects so Enums can be used.

rv...@google.com <rv...@google.com> #4Jan 12, 2023 02:28AM

Marked as fixed.

Support of Serializable objects is not enough for enums, you definitely need also the support of default values.

pr...@google.com <pr...@google.com> #5Feb 8, 2023 06:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

Issue 263061052