ImmersiveList "focusableItem" not compatible with "clickable" [263061052]

Fixed

Bug

Status Update

No update yet.

Description

re...@gmail.com

created issue #1

Dec 19, 2022 04:58PM

Component used: TV

Version used: 1.0.0-alpha03

Devices/Android versions reproduced on: Emulator (Android TV 4K API 33)

This is pretty simple to reproduce. For items within an immersive list, the focusableItem modifier should be applied to each list item in which the background should change. If focusableItem is used with clickable clickable no longer works.

I think passing an InteractionSource to focusableItem which is also shared with clickable will resolve the issue.

    val interactionSource = remember { MutableInteractionSource() }
    Box( 
        modifier = Modifier
            .onFocusChanged { focusState ->
                if (focusState.isFocused) {
                    background = Color.White
                    textColor = Color.Black
                } else {
                    background = originalColor
                    textColor = Color.White
                }
            }
            .focusableItem(index) // Note interactionSource is not available here.
            .clickable(
                onClick = onClick,
                interactionSource = interactionSource,
                indication = rememberRipple()
            )
            .size(100.dp)
            .background(
                color = background
            ), contentAlignment = Alignment.Center
    ) {
        Text(text = index.toString(), color = textColor)
    }

Comments

rv...@google.com <rv...@google.com> Dec 20, 2022 08:19AM

Reassigned to rv...@google.com.

rv...@google.com <rv...@google.com> Dec 20, 2022 12:50PM

Accepted by rv...@google.com.

rv...@google.com <rv...@google.com> #2Dec 21, 2022 11:46AM

Easy repro: Tap back key during gesture selection.

ap...@google.com <ap...@google.com> #3Jan 12, 2023 02:25AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc37dddeefb6910a229d81612a60374678e615b4
Author: Steve McKay <smckay@google.com>
Date: Wed Aug 14 23:48:25 2019

Add support for resetting library state in response to CANCEL events and clearing of selection.

Sepcifically:
- BandSelectionHelper#reset
- GestureSelectionHelper#reset
- Clearing Selection in tracker.
- Reset the OperationMonitor.
- Connect explicit clearSelection (as clients call from back button) to reset.

GestureDetector is already listening for CANCEL events, cleans up its own state internally.

Related cleanups:
- Add onSelectionCleared support to SelectionObserver class.
- Guard all runtime state checking behind DEBUG bit (mis-configuration still throws).
- Deprecate support for setting gesture/pointer tooltypes.
- Define more events in TestEvents.
- Cleanup naming and consoliate some tests in BandSelectionHelperTest.
- Remove support POINTER_UP in BandSelectionHelper...POINTER_UP is for secondary pointer
devices only, which is outside of the domain of BandSelectionHelper.

BUG: 137460699
Test: Passing, added new test related to reset behavior.
Change-Id: Ie7127571dfa95f571ac754b3ae58e03bb153cbe8

M recyclerview/recyclerview-selection/api/1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/current.txt
M recyclerview/recyclerview-selection/api/public_plus_experimental_1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/public_plus_experimental_current.txt
M recyclerview/recyclerview-selection/api/restricted_1.1.0-alpha07.txt
M recyclerview/recyclerview-selection/api/restricted_current.txt
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/BandSelectionHelperTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTracker_SingleSelectTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/GestureSelectionHelperTest.java
A recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/ResetMangerTest.java
A recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/SelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/TouchInputHandlerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestEvents.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestRunnable.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/BandSelectionHelper.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/GestureDetectorOnItemTouchListenerAdapter.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/GestureSelectionHelper.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/MotionEvents.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/MouseInputHandler.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/OperationMonitor.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/Range.java
A recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ResetManager.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/SelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/TouchInputHandler.java

https://android-review.googlesource.com/1103351

rv...@google.com <rv...@google.com> #4Jan 12, 2023 02:28AM

Marked as fixed.

Aiming to have a 1.1 beta release out soon including this fix.

All defensive check stability issues should be resolved with this CL.

pr...@google.com <pr...@google.com> #5Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

Issue 263061052