Jpeg image corruption if writing location after updating some Exif attributes [263747161]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Dec 27, 2022 02:07AM

Component used: Version used: Devices/Android versions reproduced on: Samsung A32 (sm-a325f) Android 12 (also A12/A13 mentioned in b/263289024)

When reporting bugs, please always include:

A full bug report as an attachment, captured during or shortly after experiencing the issue.

Bugreport on Samsung sm-a325f:

About 17:41 Install and launch the first test app to run with self-copy-exif and write-location-data on

About 17:42 Install and launch the second test app to take a picture

Reproduction steps, being as specific as possible.

I’m working for the CameraX project and one Exif location related issue (b/263289024) was reported. The issue seems like that can be reproduced on specific Samsung Android 12 devices (A13, A32, A12). I can reproduce the issue on a Samsung A32 (sm-a325f) Android device. After some investigation, I wrote a sample app which can reproduce the issue.

i. Please refer to the sample project in the attached MyApplication-ExifLocationIssue.zip. I use CameraX to capture a JPEG image on a Samsung A32 device and use it (put in the project assets folder) to reproduce the issue. Please compile and run the sample app to check the following cases and results: (This can be run on any device)

Self copy Exif Write location data Decode result file

Yes Yes Failed

Yes No Passed

No Yes Passed

Yes No Passed

ii. I don’t know what affects the test results. When using the above sample app, no matter which location provider data is set, the issue can be reproduced. But if I set the location data by CameraXBasic sample app just as what is reported in b/263289024. The issue only happens if the location data is specified as LocationManager#FUSED_PROVIDER data. The issue won’t happen when setting it as LocationManager#GPS_PROVIDER data. Please compile the attached CameraXBasic-WriteFusedLocation.zip and modify the location provider setting in the CameraFragment.kt to check the results. (This can be run on the problematically devices)

Self copy Exif	Write location data	Decode result file
Yes	Yes	Failed
Yes	No	Passed
No	Yes	Passed
Yes	No	Passed

How reproducible the issue is on the affected device.

100% on Samsung A32 (sm-a325f) Android 12 device

If known, how reproducible the issue is on other devices and OS versions.

Where possible, please also provide:

A sample project that reproduces the issue.

Please see the attached sample apps

A screenrecord or screenshots showing the issue.

dumpstate-2022-12-26-17-43-03.zip

13 MB

Download

deleted

Restricted+

0 B

CameraXBasic-WriteFusedLocation.zip

680 KB

Download

Comments

ap...@google.com <ap...@google.com> #2Jan 3, 2023 03:18AM

Building note: run ./gradlew ... -x processReleaseMetadata

ib...@google.com <ib...@google.com> #3Mar 6, 2023 01:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018

Fix ViewModel proguard rules

It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection

Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c

M lifecycle/viewmodel/proguard-rules.pro

https://android-review.googlesource.com/727573

https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38

ib...@google.com <ib...@google.com> #4Mar 6, 2023 04:04PM

Thanks!

ib...@google.com <ib...@google.com> #5Mar 6, 2023 04:17PM

I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!

ib...@google.com <ib...@google.com> #6Mar 6, 2023 04:23PM

it will be part of rc02

ib...@google.com <ib...@google.com> #7Mar 6, 2023 04:54PM

When will rc02 be released?

ch...@google.com <ch...@google.com> #8Mar 7, 2023 10:00AM

RC2 was released already -

https://developer.android.com/topic/libraries/support-library/revisions#28-0-0-rc2

ib...@google.com <ib...@google.com> #9Mar 7, 2023 10:07AM

But it's not fixed:

https://twitter.com/ianhlake/status/1035260731665436672

ib...@google.com <ib...@google.com> #10Mar 7, 2023 02:09PM

Well, it wasn't released properly.

ap...@google.com <ap...@google.com> #11Mar 7, 2023 04:16PM

They updated version 2.0.0 in the today so I can update my app for now :D. Thanks!

ib...@google.com <ib...@google.com> Mar 7, 2023 04:16PM

Marked as fixed.

mw...@gmail.com <mw...@gmail.com> #12Mar 7, 2023 05:51PM

<LinearLayout xmlns:android="

http://schemas.android.com/apk/res/android"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="match_parent">
<LinearLayout android:layout_width="match_parent"
android:id="@+id/linearLayout1"
android:gravity="center"
android:layout_height="50dp">
<ImageView android:id="@+id/imageView1"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:src="@drawable/logo"
android:paddingRight="30dp"
android:layout_gravity="left"
android:layout_weight="0" />
<View android:layout_height="wrap_content"
android:id="@+id/view1"
android:layout_width="wrap_content"
android:layout_weight="1" />
<Button android:id="@+id/categorybutton"
android:background="@drawable/button_bg"
android:layout_height="match_parent"
android:layout_weight="0"
android:layout_width="120dp"
style="@style/CategoryButtonStyle"/>
</LinearLayout>

<fragment android:id="@+id/headlines"
android:layout_height="fill_parent"
android:name="com.example.android.newsreader.HeadlinesFragment"
android:layout_width="match_parent" />
</LinearLayout>

ib...@google.com <ib...@google.com> #13Mar 7, 2023 05:58PM

Hi want to play

na...@google.com <na...@google.com> #14Dec 13, 2023 06:33PM

Alluda

na...@google.com <na...@google.com> #15Nov 13, 2024 06:19PM

Thankfully service