Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
mg...@google.com <mg...@google.com>
mg...@google.com <mg...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 428f0ec685ff80035c0511c0cdb12b9770b6159c
Author: Maxim Savoskin <maximsavoskin@gmail.com>
Date: Mon Mar 29 13:20:52 2021
[GH] [Lifecycle] [Lint] fixes b/183696616 : KtCallExpression is not always the first in the list
## Proposed Changes
KtCallExpression is not always the first in the list. In this case, it is KtModifierList.
## Testing
Test: ./gradlew test lint buildOnServer
## Issues Fixed
Fixes:https://issuetracker.google.com/issues/183696616
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/147 .
Resolves #147
Github-Pr-Head-Sha: 3c2693e2f4cceb367c9c169749d1391a9da2740f
GitOrigin-RevId: a6440720029b1c0c702207f1393d3b01180691b8
Change-Id: I9b4383329b9ece85e3bffa4a9bf8e8a3f0c3d84a
M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
https://android-review.googlesource.com/1656820
Branch: androidx-main
commit 428f0ec685ff80035c0511c0cdb12b9770b6159c
Author: Maxim Savoskin <maximsavoskin@gmail.com>
Date: Mon Mar 29 13:20:52 2021
[GH] [Lifecycle] [Lint] fixes
## Proposed Changes
KtCallExpression is not always the first in the list. In this case, it is KtModifierList.
## Testing
Test: ./gradlew test lint buildOnServer
## Issues Fixed
Fixes:
This is an imported pull request from
Resolves #147
Github-Pr-Head-Sha: 3c2693e2f4cceb367c9c169749d1391a9da2740f
GitOrigin-RevId: a6440720029b1c0c702207f1393d3b01180691b8
Change-Id: I9b4383329b9ece85e3bffa4a9bf8e8a3f0c3d84a
M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
ap...@google.com <ap...@google.com> #4
Will you guys be releasing a hot fix 2.3.2 for this?
ap...@google.com <ap...@google.com> #5
Any updates about when this is going live?
Description
Component used:
androidx.lifecycle
Version used:
2.5.1
Devices/Android versions reproduced on: n/a
It's common to test view models in use tests but there is currently no way to close a view model without creating a VM Store, Factory etc. It would be nice if there was a test artifact that could help you provide a view model and close it.