RecyclerView invokes adapter onBind while target view to be bound is temporarily detached [265347515]

Fixed

Bug

Status Update

No update yet.

Description

ry...@google.com

created issue #1

Jan 12, 2023 11:02PM

Quoting Adam Powell on an internal issue:

When we investigated [a crash with Compose in a Google app] it looks like something between RecyclerView/LinearLayoutManager is leaving the view in a temporarily detached state via ViewGroup.detachViewFromParent during the bind operation, which will disrupt the functioning of many Jetpack libraries that use ViewTreeFoo service locators to discover dependencies, Compose included. We should definitely work to fix this so that we only invoke binding operations from adapters while the view is either fully attached or fully detached.

Comments

ry...@google.com <ry...@google.com> #2Jan 12, 2023 11:03PM

This is with the latest CameraX 1.1.0-beta03.

ap...@google.com <ap...@google.com> #3Mar 2, 2023 03:35AM

Marked as fixed.

Thanks for reporting the issue. We will look into the bug and update here soon.

hu...@google.com <hu...@google.com> #4Mar 6, 2023 08:06PM

We will catch this exception while clarify what is going wrong in the meantime.

Hi Shuzen
We've got this public issue from developers where querying CameraCharacteristics.CONTROL_ZOOM_RATIO_RANGE seems to cause crash on some cheap devices in India.
Is this because these cheap devices do not pass CTS ?

hu...@google.com <hu...@google.com> #5Mar 6, 2023 08:08PM

Is it possible to get a bugreport from those devices?

ry...@google.com <ry...@google.com> #6Mar 7, 2023 01:09AM

One of our project members can potentially get their hands on one of these devices but we currently don't have access to one. It's probably a lot easier for you folks to get one since we can't really afford to buy phones.

Ideally you could get some of these cheap Indian/Chinese phones for the CameraX device lab.

This Jio device is Google certified but in my experience most non-Pixel phones are pretty far from genuinely passing the CTS and have a lot of failures that aren't just flaky tests. I'm not sure how they get their devices certified but apparently there are waivers. Google doesn't do the certification but rather third parties do, and it's possible they're simply cutting corners or acting in a corrupt way. Usually there are a lot of failing CTS Camera tests. It doesn't help that a lot of those CTS Camera tests are super flaky without a high quality device and a proper testing setup with proper lightning, etc. They can still fail from flakiness even with that setup. Probably why they can so easily skip meeting these requirements, since the certification companies are used to flaky / failing tests and aren't really doing their job properly.

Message last modified on Mar 7, 2023 01:14AM

hu...@google.com <hu...@google.com> #7Mar 7, 2023 03:36PM

We have a project member in India who could buy one of these phones and since they're so cheap (around $80 or something) I could cover that but in general I don't really want to be buying phones we don't really need.

Message last modified on Mar 7, 2023 03:47PM

ap...@google.com <ap...@google.com> #8Apr 27, 2023 06:58PM

Hi ,

Thanks for the informations. You are right, it's possible that the devices are not genuinely passing the CTS.
Regardless, we will fix this in CameraX. (Thanks for letting us know BTW)
We will also try to get one of these device to test if there are other issues.

Scott

ju...@google.com <ju...@google.com> #9May 24, 2023 07:37PM

This crash looks similar to the one in b/216667482. We might want to do a similar workaround here.

pr...@google.com <pr...@google.com> #10Oct 18, 2023 08:42PM

It seems there are two approaches
1) Fix it generally
2) Have a quirk for this, only enable the fix when device has this quirk.

The problem with the quirk is that it is too easy to miss some other devices that have this issue too.
Having a general fallback that works reasonably can fix the issue for all problematic devices.
(In these two cases, they are both reasonable to return false if the key access failed)

But I do think it has benefits to have a quirk so that we know exactly what workaround we handled in CameraX.

Maybe , we can have a type of quirk or workaround that we apply generally for all devices ?

WDYT?