RecyclerView invokes adapter onBind while target view to be bound is temporarily detached [265347515]

Fixed

Bug

Status Update

No update yet.

Description

ry...@google.com

created issue #1

Jan 12, 2023 11:02PM

Quoting Adam Powell on an internal issue:

When we investigated [a crash with Compose in a Google app] it looks like something between RecyclerView/LinearLayoutManager is leaving the view in a temporarily detached state via ViewGroup.detachViewFromParent during the bind operation, which will disrupt the functioning of many Jetpack libraries that use ViewTreeFoo service locators to discover dependencies, Compose included. We should definitely work to fix this so that we only invoke binding operations from adapters while the view is either fully attached or fully detached.

Comments

ry...@google.com <ry...@google.com> #2Jan 12, 2023 11:03PM

The fix: https://github.com/androidx/androidx/pull/212

ap...@google.com <ap...@google.com> #3Mar 2, 2023 03:35AM

Marked as fixed.

Amended the behavior slightly to find the best match from the requested style.

hu...@google.com <hu...@google.com> #4Mar 6, 2023 08:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6e7a1ffacde6ead3acbff09514503e896d3c8bf3
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Mar 29 11:04:25 2022

TypefaceCompatApi29 finds best from requested style

This causes fonts closer to the desired style to be chosen on
resolution.

Test: ./gradlew :core:core:cAT
Bug:

b/194553426

Relnote: "TypefaceCompat will now respect both requested and loaded
style information on API 29+. This is a behavior change when the loaded
fonts are not FontWeight.Normal or FontWeight.Bold, as the actual loaded
weight and style will be used. For more information see

b/194553426

"

Change-Id: I1f90279afa68afa450bb98eb7c5237464c5f57d8

M core/core/src/androidTest/java/androidx/core/graphics/TypefaceCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/samplexmlfont_medium.xml
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/2047984

hu...@google.com <hu...@google.com> #5Mar 6, 2023 08:08PM

https://github.com/androidx/androidx/commit/a2ac4383d3c6451a849d26830be91f888c76bf53

ry...@google.com <ry...@google.com> #6Mar 7, 2023 01:09AM

Since it's not listed here, repeating:

This was solved by github contribution https://github.com/androidx/androidx/pull/212

Message last modified on Mar 7, 2023 01:14AM

hu...@google.com <hu...@google.com> #7Mar 7, 2023 03:36PM

Thanks for the explanation!

~~I'm wondering if there will be versioning issues re. Android platform support vs. AndroidX?~~ (NVM, this is all AndroidX).

Message last modified on Mar 7, 2023 03:47PM

ap...@google.com <ap...@google.com> #8Apr 27, 2023 06:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit e8d8836df99cf5e0d1d4bc318947d89d4103c569
Author: Ryan Mentley <ryanmentley@google.com>
Date: Wed Mar 08 18:26:56 2023

Ensure that ViewPager2 is on the latest version when used with an updated recyclerview

As discussed at

https://issuetracker.google.com/issues/265347515#comment4,
ViewPager2 had a workaround for that bug that now crashes when the bug is
not present. To fix this, we need to ensure that ViewPager2 is on a
version containing the corresponding fix in ViewPager2.

Bug: 265347515
Bug: 271618925
Test: None (TBD?)
Change-Id: I18a5140755c15a0c93e2647207152b679e463233

M recyclerview/recyclerview/build.gradle

https://android-review.googlesource.com/2478185

ju...@google.com <ju...@google.com> #9May 24, 2023 07:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.recyclerview:recyclerview:1.3.1-rc01

pr...@google.com <pr...@google.com> #10Oct 18, 2023 08:42PM