Hebrew SMS is not sent on API 33 [266201208]

Fixed

Bug

Status Update

No update yet.

Description

db...@gmail.com

created issue #1

Jan 21, 2023 12:42PM

Please Read: https://developer.android.com/studio/report-bugs.html#emulator-bugs

Android Studio Version: Unknown

Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.14-9322596 HAXM / KVM Version: HAXM 7.6.5

Android SDK Tools: 26.1.1

Host Operating System: Windows 10 Pro

CPU Manufacturer: Intel CPU Virtualization is supported 64-bit CPU

RAM: 16327 MB

GPU: GPU #1 Make: 1002 Model: AMD Radeon HD 7570 Device ID: 675d

Build Fingerprint:

AVD Details: Name: Pixel_2_API_33_2 CPU/ABI: x86_64 Path: C:\Users\Doron.android\avd\Pixel_2_API_33_2.avd Target: google_apis_playstore [Google Play] (API level 33) Skin: pixel_2 SD Card: 512M AvdId: Pixel_2_API_33_2 PlayStore.enabled: true avd.ini.displayname: Pixel 2 API 33 2 avd.ini.encoding: UTF-8 disk.dataPartition.size: 6442450944 fastboot.chosenSnapshotFile: fastboot.forceChosenSnapshotBoot: no fastboot.forceColdBoot: no fastboot.forceFastBoot: yes hw.accelerometer: yes hw.arc: false hw.audioInput: yes hw.battery: yes hw.camera.back: virtualscene hw.camera.front: emulated hw.cpu.ncore: 4 hw.dPad: no hw.device.hash2: MD5:55acbc835978f326788ed66a5cd4c9a7 hw.device.manufacturer: Google hw.device.name: pixel_2 hw.gps: yes hw.gpu.enabled: yes hw.gpu.mode: auto hw.initialOrientation: Portrait hw.keyboard: yes hw.lcd.density: 420 hw.lcd.height: 1920 hw.lcd.width: 1080 hw.mainKeys: no hw.ramSize: 1536 hw.sdCard: yes hw.sensors.orientation: yes hw.sensors.proximity: yes hw.trackBall: no image.sysdir.1: system-images\android-33\google_apis_playstore\x86_64
runtime.network.latency: none runtime.network.speed: full showDeviceFrame: yes skin.dynamic: yes tag.display: Google Play tag.id: google_apis_playstore vm.heapSize: 228

Steps to Reproduce Bug:

Write Hebrew characters when sending a message - the message is not sent. Same happens if sent programmatically from another app. The happens on API 33 but not on API 29.

Expected Behavior:

Observed Behavior:

screenshot.png

133 KB

View

Download

Comments

db...@gmail.com <db...@gmail.com> #2Jan 21, 2023 12:44PM

I have the same issue. There should be a built in method for setting title dynamically.

Message last modified on Jan 21, 2023 01:01PM

vi...@google.com <vi...@google.com> Jan 25, 2023 02:24PM

Assigned to an...@google.com.

bo...@google.com <bo...@google.com> Jan 25, 2023 07:16PM

Reassigned to wd...@google.com.

wd...@google.com <wd...@google.com> #3Jan 25, 2023 07:53PM

Assigned to wd...@google.com.

I would expect a simple API inside the navigation architecture as this is quite a common design requirement

Message last modified on Jan 25, 2023 07:57PM

wd...@google.com <wd...@google.com> Mar 10, 2023 02:16AM

Accepted by wd...@google.com.

wd...@google.com <wd...@google.com> #4Mar 10, 2023 05:43PM

To me, it is perfectly reasonable to remove the `android:label` attribute from the nav_graph.xml and set the title manually based on the arguments bundle.

wd...@google.com <wd...@google.com> #5Mar 10, 2023 09:19PM

I'm currently working around this limitation by adding an "onNavigatedListener" to my root Activity and using the "

destination.id" property against a lookup mapping to a desired title:

private val onNavigatedListener: (NavController, NavDestination) -> Unit = { _, destination ->
this.title = titleLookup[

destination.id]
}

wd...@google.com <wd...@google.com> Mar 10, 2023 10:20PM

Marked as fixed.

db...@gmail.com <db...@gmail.com> #6Aug 1, 2023 07:55PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a958e3d36aeca8767d1c3cb53caa55ba3dd1c65d
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 28 16:06:01 2018

Allow {argName} parameterized labels

Support parameterized labels similarly
to how ActivityNavigator uses dataPattern by
using {argName} blocks in the label.

Test: testapp works
BUG: 80267266
Change-Id: I923f3a6e11662c4364d4b3f0757361edea016cec

M navigation/integration-tests/testapp/src/main/res/navigation/nav_main.xml
M navigation/integration-tests/testapp/src/main/res/values/strings.xml
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnNavigatedListener.java

https://android-review.googlesource.com/837143

https://goto.google.com/android-sha1/a958e3d36aeca8767d1c3cb53caa55ba3dd1c65d

wd...@google.com <wd...@google.com> #7Aug 1, 2023 07:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5e475aa0a00390755a9d4a9260c827b72ec81eb2
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 28 15:48:29 2018

Pass Bundle of arguments to OnNavigatedListeners

Instead of just passing the NavDestination,
pass both the NavDestination and the (optional)
Bundle of arguments. This allows listeners to
dynamically update their content rather than only
relying on the fixed data from the NavDestination.

Test: testapp still works
BUG: 80267266
Change-Id: I80f0e65526711a2ba11b7a12fc907a1b9dbe83e9

A navigation/common/src/main/java/androidx/navigation/NavBackStackEntry.java
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/NavigationActivity.kt
M navigation/runtime/api/1.0.0-alpha08.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java
M navigation/ui/src/main/java/androidx/navigation/ui/AbstractAppBarOnNavigatedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnNavigatedListener.java
M navigation/ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/ui/src/main/java/androidx/navigation/ui/ToolbarOnNavigatedListener.java

https://android-review.googlesource.com/837142

https://goto.google.com/android-sha1/5e475aa0a00390755a9d4a9260c827b72ec81eb2

Message last modified on Aug 1, 2023 08:00PM

wd...@google.com <wd...@google.com> #8Aug 1, 2023 08:41PM

This is fixed internally and will be available in 1.0.0-alpha08.

You'll be able to use labels such as "Hi {name}!" and the NavigationUI methods will automatically populate the {argName} elements with the appropriately named argument.

[Deleted User] <[Deleted User]> #9Feb 8, 2024 12:06AM

Comment #8

,

Sounds good. I understand how I would pass the argument values during normal navigation, but how would I pass the argument to the starting fragment (set in `app:startDestination`)?