Status Update
No update yet.
Comments
do...@gmail.com
Branch: androidx-master-dev
commit 05f347890c62aaf1f585b9adbbeb75832d3c8b2c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 27 17:05:17 2018
Make Nav Direction classes extend top level Direction classes.
Directions classes who's destination is contained in a nav graph with
top level actions will now extend the nav graph's direction class
enabling global actions to be available to lower layers of the graph.
Bug: 79871405
Test: ./gradlew :navigation:navigation-safe-args-generator:test
Change-Id: Id59d8547dacb33c0d75ddd282754d87b499c2b9b
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/GeneratorOutput.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavSafeArgsGenerator.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/ext/NavJavaPoet_ext.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
A navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/TestUtils.kt
A navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginDirections.java
A navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/LoginFragmentDirections.java
A navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/MainFragmentDirections.java
A navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Finish.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/SanitizedMainFragmentDirections.java
A navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
ml...@google.com
bo...@google.com
wd...@google.com
I think it has to do with your dns configuration on host. Since you mentioned that running command line -netdelay none -netspeed full -dns-server '2001:4860:4860::8844,2001:4860:4860::8888,8.8.8.8,8.8.4.4' works for you. I wonder if you could run emulator with command line
-verbose and send the log to us. It will print out the dns server being used.
do...@gmail.com
Thank you for your reply! Here you can find the log. It's worth noting that I haven't changed any default settings.
wd...@google.com
VERBOSE | Found 2 DNS servers:
VERBOSE | fe80::16de:39ff:fe44:5806
VERBOSE | 192.168.1.1
It looks like emulator is trying to use fe80::16de:39ff:fe44:5806 which is the link-local address. Emulator always seem to have a problem with local addresses.
wd...@google.com
Hi @maze, do you think it would make sense for emulator to switch to 2001:4860:4860::8844 when ipv6 link local address is present in the local dns config file? Apparently, there is some issue with DNS probe when the host DNS address is link local.
ma...@google.com
fe80::16de:39ff:fe44:5806%eth0 (eth0 being the relevant nic)
or
fe80::16de:39ff:fe44:5806%2 (2 being the ifindex of the relevant nic)
are valid ips.
See
IFIRC many of the Linux kernel APIs (like connect(), sendto(), sendmsg(), bind()) fail when you pass in a scope-less link local IPv6 address, because they're insufficiently defined.
Furthermore link local traffic is not forwardable (simply because it's link local...)
Honestly, this feels like a network misconfiguration, as a link local DNS server is simply not reachable (without something like NAT or other hacks) from a VM, without that VM being quite literally bridged into the network (which doesn't work with normal wifi networks, as they don't support ethernet bridging) - AFAIK Android Emulator doesn't bridge (and I don't think that would work for other reasons - including that bridging would need admin privs)
Fixes in order of preference:
(a) The network should 'simply' be fixed to return a non-link local DNS IPv6 address.
(b) Make Android Studio simply ignore fe80::/64 dns servers (strip them out, you'd be left with just 192.168.1.1) - though this may end up with Android Studio networking coming up without any ipv6 connection.
(c) You could in such a case use a hardcoded DNS server - like the Google DNS ips you mentioned in #6.
However, not using the DNS provided by the system is usually something that shouldn't be done (for privacy reasons...)
As such I'd recommend doing (a) and/or (b) and perhaps adding a flag (or config option or something) to manually specify / override the DNS servers to use (perhaps one for ipv4, one for ipv6??).
To make it easier on users you could have some sort of drop down box (network provided, google dns, cloudflare dns, quad9, custom) and a field to fill in.
Note that using a global DNS resolver like Google DNS will result in local stuff (like router.lan or gateway.local) not resolving, but that's likely fine for the emulator.
(d) You could run a dns cache as part of Android Studio (and replace the link local IP with its IP), or manually forward the packets (assuming the VM even sends them out) with some NAT66 or even NAT64.
I'm including this for completeness, but I wouldn't recommend it, seems like a lot of needless complexity in the emulator.
ma...@google.com
And of course ::1 or
wd...@google.com
RE#7 Thanks for the detailed explanation and really appreciate the solution mentioned in
Fixes in order of preference:
(a) The network should 'simply' be fixed to return a non-link local DNS IPv6 address.
(b) Make Android Studio simply ignore fe80::/64 dns servers (strip them out, you'd be left with just 192.168.1.1) - though this may end up with Android Studio networking coming up without any ipv6 connection.
(c) You could in such a case use a hardcoded DNS server - like the Google DNS ips you mentioned in #6.
However, not using the DNS provided by the system is usually something that shouldn't be done (for privacy reasons...)
As such I'd recommend doing (a) and/or (b) and perhaps adding a flag (or config option or something) to manually specify / override the DNS servers to use (perhaps one for ipv4, one for ipv6??).
I think emulator should implement (b) at least and (c) should be only enabled if an option is provided.
do...@gmail.com
Apparently, the issue has been resolved in Android Emulator 32.1.11-9536276. After updating and restarting AS I see that network works.
However, if I run from CL, network works but log is the same for 32.1.11 with pixel 2 API 33:
VERBOSE | Found 2 DNS servers:
VERBOSE | fe80::16de:39ff:fe44:5806
VERBOSE | 192.168.1.1
wd...@google.com
RE#11 Ok, let me see what has been changed from build 9456632 to build 9536276. Thanks again for the information.
wd...@google.com
RE#11
I found the culprit. It's this /etc/resolve.conf are passed into slirp instances.
In Android Emulator 32.1.11-9536276, the aforementioned CL was not cherry-picked while in emulator 31.3.15-9456632, the CL was merged. Therefore, the "problematic" link local DNS is passed into emulator 31 release but not emulator 32 release.
Solution: make sure the
go...@gmail.com
wd...@google.com
RE#15 It seems like this is a different topic if you cannot install android studio on your laptop. Would you like to file a different bug?
Description
Description has been deleted.