Modal Bottom Sheet bugging with 5 items [268411386]

Fixed

Bug

Status Update

No update yet.

Description

pi...@outlook.com

created issue #1

Feb 9, 2023 02:01AM

Jetpack Compose version: material3:1.1.0-alpha06
Jetpack Compose component used: Modal Bottom Sheet/Material 3
Android Studio Build: Giraffe 2022.3.1 Canary 3 / #AI-223.7571.182.2231.9532861
Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:
1. Create a Jetpack compose app
2. Add material 3 dependency
3. Create a modal bottom sheet with 5 items
4. See output

As attached in the screenshots, the new modal bottom sheet bugs when using 5 items. All of those buttons are a ListItem.

image.png

84 KB

View

Download

image1.png

101 KB

View

Download

Comments

pi...@outlook.com <pi...@outlook.com> #2Feb 9, 2023 02:04AM

Sorry, just correcting the Jetpack compose version :)
It's actually 1.2.1 using compiler version 1.4.2

jo...@google.com <jo...@google.com> #3Feb 9, 2023 09:12AM

Reassigned to se...@google.com.

Hi, can you please provide a full repro project? A zip or git repo would be best.

pi...@outlook.com <pi...@outlook.com> #4Feb 9, 2023 10:31AM

Sure, it's

https://github.com/musicorum-app/mobile/tree/dev and the bottom sheet is implemented at

https://github.com/musicorum-app/mobile/blob/dev/app/src/main/java/io/musicorum/mobile/components/TrackSheet.kt

se...@google.com <se...@google.com> Feb 10, 2023 02:41PM

Reassigned to ma...@google.com.

se...@google.com <se...@google.com> Feb 28, 2023 09:08PM

Reassigned to jo...@google.com.

ap...@google.com <ap...@google.com> #5Mar 1, 2023 05:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5621ff29f7c4d03bda2315bfa3d0a6314df85728
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Feb 10 11:12:00 2023

Fix ModalBottomSheet's HalfExpanded anchor offset

We used the `sheetSize` to calculate the HalfExpanded offset instead of the screen height.

Test: Updated modalBottomSheet_defaultStateForLargeContentIsHalfExpanded
Relnote: Fixed an issue where `ModalBottomSheet`'s `HalfExpanded` state was calculated incorrectly and the sheet would appear to be floating.
Bug: 268411386
Change-Id: I45e84ba00263f4bea61a3abac54bf05a6494bce8

M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

https://android-review.googlesource.com/2430112

se...@google.com <se...@google.com> #6Mar 1, 2023 05:52PM

Marked as fixed.

Fix landing in alpha-08

na...@google.com <na...@google.com> #7Mar 8, 2023 07:51PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-alpha08