Navigation with Fragments does not correctly update BottomNavigationMenu [270447657]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Feb 22, 2023 11:41PM

The most recent version of Navigation (`2.6.0-alpha06`) caused a regression where if you attempt to restore a backstack with multiple entries using `BottomNavigation`, the menu icon is not updated correctly.

Comments

ap...@gmail.com <ap...@gmail.com> #2Feb 23, 2023 01:08AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1381476

ap...@google.com <ap...@google.com> #3Mar 1, 2023 01:40AM

This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.

jb...@google.com <jb...@google.com> #4Mar 1, 2023 01:42AM

Marked as fixed.

Thank you, that's great to hear. Looking forward to it.

ap...@google.com <ap...@google.com> #5Mar 1, 2023 11:50PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 91e0659733e097aabfb5801caccbf6f40d2f4a72
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436153

na...@google.com <na...@google.com> #6Mar 8, 2023 07:51PM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit 94827a2939f3a4d2c8d08e8dc93d53330de56806
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436736

ap...@google.com <ap...@google.com> #7Mar 16, 2023 12:41AM

Project: platform/frameworks/support
Branch: snap-temp-L46100000699831674

commit b1fbee9fc7b04ae2cb8868774a714c134c86f865
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436740

pr...@google.com <pr...@google.com> #8Mar 22, 2023 08:21PM

Project: platform/frameworks/support
Branch: snap-temp-L91000000699844097

commit 81272b7a61a520f9be7803eefd58bf8143b3fd50
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436541