Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit dd000ea5e6eb3a8f07b869595ca62aa2fb781d12
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Feb 22 19:42:13 2021
Fix for broken rememberSaveable { mutableStateOf(0) } with navigation-compose
Previously we were converting MutableState into a parcelable structure only for a direct child of the saving list. It was incorrect as SaveableStateHolder used in navigation is wrapping the state of the screen as a value into a Map. Now we will recursively iterate through List/Maps and covert all inner MutableState objects.
Fixes: 180042685
Fixes: 180701630
Test: new tests in ActivityRecreationTest
Relnote: Fix for broken rememberSaveable { mutableStateOf(0) } when used inside a destination of navigation-compose.
Change-Id: I1312b5b210dde32250945d164a2f3a1b574cb0a8
M compose/runtime/runtime-saveable/src/androidAndroidTest/AndroidManifest.xml
M compose/runtime/runtime-saveable/src/androidAndroidTest/kotlin/androidx/compose/runtime/saveable/ActivityRecreationTest.kt
M compose/runtime/runtime-saveable/src/commonMain/kotlin/androidx/compose/runtime/saveable/RememberSaveable.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/DisposableSaveableStateRegistry.android.kt
https://android-review.googlesource.com/1599261
Branch: androidx-main
commit dd000ea5e6eb3a8f07b869595ca62aa2fb781d12
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Feb 22 19:42:13 2021
Fix for broken rememberSaveable { mutableStateOf(0) } with navigation-compose
Previously we were converting MutableState into a parcelable structure only for a direct child of the saving list. It was incorrect as SaveableStateHolder used in navigation is wrapping the state of the screen as a value into a Map. Now we will recursively iterate through List/Maps and covert all inner MutableState objects.
Fixes: 180042685
Fixes: 180701630
Test: new tests in ActivityRecreationTest
Relnote: Fix for broken rememberSaveable { mutableStateOf(0) } when used inside a destination of navigation-compose.
Change-Id: I1312b5b210dde32250945d164a2f3a1b574cb0a8
M compose/runtime/runtime-saveable/src/androidAndroidTest/AndroidManifest.xml
M compose/runtime/runtime-saveable/src/androidAndroidTest/kotlin/androidx/compose/runtime/saveable/ActivityRecreationTest.kt
M compose/runtime/runtime-saveable/src/commonMain/kotlin/androidx/compose/runtime/saveable/RememberSaveable.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/DisposableSaveableStateRegistry.android.kt
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 9307154b17ee735c581b627f27401de2b1928149
Author: sanura <sanura@google.com>
Date: Wed Mar 08 18:37:13 2023
Deprecate ComponentActivity.onBackPressed()
ComponentActivity.onBackPressed() should be
deprecate so that developers building on top
of ComponentActivity don't override it and
instead use OnBackPressedDispatcher.
RelNote: "`ComponentActivity.onBackPressed()`
has now been deprecated in favor of the APIs
for handling back. Developers should now
utilize the `OnBackPressedDispatcher`, rather
than overriding this method."
Fixes: 271596918
Test: ./gradlew bOS
Change-Id: Ibce2f664a8d73cb1df06c20918752fb3dfb44e0c
A activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
A activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
https://android-review.googlesource.com/2472947
Branch: androidx-main
commit 9307154b17ee735c581b627f27401de2b1928149
Author: sanura <sanura@google.com>
Date: Wed Mar 08 18:37:13 2023
Deprecate ComponentActivity.onBackPressed()
ComponentActivity.onBackPressed() should be
deprecate so that developers building on top
of ComponentActivity don't override it and
instead use OnBackPressedDispatcher.
RelNote: "`ComponentActivity.onBackPressed()`
has now been deprecated in favor of the APIs
for handling back. Developers should now
utilize the `OnBackPressedDispatcher`, rather
than overriding this method."
Fixes: 271596918
Test: ./gradlew bOS
Change-Id: Ibce2f664a8d73cb1df06c20918752fb3dfb44e0c
A activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
A activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
Description
[1]:
[2]: