Ensure Navigation does not crash when adding an unknown fragment [274167493]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 17, 2023 09:53PM

While it is not recommended to add fragments to the fragment manager outside of navigation, as long as the fragment transaction does not use `addToBackStack(true)`, Navigation should at least not crash.

Comments

ap...@google.com <ap...@google.com> #2Mar 17, 2023 10:49PM

It looks like this was fixed in https://android.googlesource.com/platform/frameworks/support/+/b6fb33662acd6608a29e4610b9d9cf73a191a92c, which is included in 1.3.0-alpha01. I'll follow up internally whether it's worth making a quick 1.2.6 release to fix this issue.

jb...@google.com <jb...@google.com> #3Mar 17, 2023 10:55PM

Marked as fixed.

For the avoidance of doubt, I think it's just the three lines in RemotePlaybackClient that are needed from the ref'd commit to fix the issue.

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

The fix for this is in mediarouter:1.2.6 (released 2022-01-26).

Issue 274167493

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 17, 2023 10:49PM

jb...@google.com <jb...@google.com> #3Mar 17, 2023 10:55PM

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

Add comment

Issue metadata