Ensure Navigation does not crash when adding an unknown fragment [274167493]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 17, 2023 09:53PM

While it is not recommended to add fragments to the fragment manager outside of navigation, as long as the fragment transaction does not use `addToBackStack(true)`, Navigation should at least not crash.

Comments

ap...@google.com <ap...@google.com> #2Mar 17, 2023 10:49PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1381476

jb...@google.com <jb...@google.com> #3Mar 17, 2023 10:55PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

Thank you, that's great to hear. Looking forward to it.

Issue 274167493

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 17, 2023 10:49PM

jb...@google.com <jb...@google.com> #3Mar 17, 2023 10:55PM

pr...@google.com <pr...@google.com> #4Mar 22, 2023 08:22PM

Add comment

Issue metadata