Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 16c5a4617aa5d0709ffe27cef015e001b31de79b
Author: George Mount <mount@google.com>
Date: Mon Apr 10 13:31:49 2023
Fix leak from ReportFullyDrawnExecutor
Fixes: 277434271
The runnable was not being removed immediately after the activity
was destroyed. This removes it when it becomes destroyed so that
it can be collected without delay.
Test: new test, exemplar test
Change-Id: Id2ff2311e16d89fc7309a6e99f302cf3e8d9d595
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityReportFullyDrawnTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
https://android-review.googlesource.com/2530063
Branch: androidx-main
commit 16c5a4617aa5d0709ffe27cef015e001b31de79b
Author: George Mount <mount@google.com>
Date: Mon Apr 10 13:31:49 2023
Fix leak from ReportFullyDrawnExecutor
Fixes: 277434271
The runnable was not being removed immediately after the activity
was destroyed. This removes it when it becomes destroyed so that
it can be collected without delay.
Test: new test, exemplar test
Change-Id: Id2ff2311e16d89fc7309a6e99f302cf3e8d9d595
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityReportFullyDrawnTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.activity:activity:1.7.1
ty...@gmail.com <ty...@gmail.com> #4
Update
Description
Version used: 1.7.0
Devices/Android versions reproduced on: API 33
If this is a bug in the library, we would appreciate if you could attach:
Example project attached
Description:
It appears that ComponentActivity$ReportFullyDrawnExecutorApi16Impl.this$0 leaks memory when used in an ActivityScenario if the ActivityScenario is used to recreate the Activity soon after the Activity has been launched.
Reproduction steps:
1. Create an Activity that extends ComponentActivity
2. Set a content view for the Activity in the onCreate using either setContentView(View) or setContent { <Composable> }
3. Create an instrumented test that uses LeakCanary's DetectLeaksAfterTestSuccess Test Rule
4. In the test: Launch the Activity using ActivityScenario, and then call "recreate" on the ActivityScenario
5a. Expected result: The test launches the Activity, recreates it, and the test passes.
5b. Actual result: The test launches the Activity, recreates it, and then LeakCanary detects a memory leak from ComponentActivity$ReportFullyDrawnExecutorApi16Impl.this$0 leaking an instance of the Activity.
This issue does not occur for ComponentActivity instance that do not set a content view in onCreate, and does not occur for regular android.app.Activity instances.
I have attached an example project with eight instrumented tests that show case this issue. In the ExampleInstrumentedTest.kt tests `launchExampleViewActivityAndRecreate` and `launchExampleComposeActivityAndRecreate` both fail, and all other tests succeed. The expected behaviour is that all tests should pass.