Expose alternate method to calculate light mode and dark mode for enableEdgeToEdge [278263793]

Fixed

Feature Request

Status Update

No update yet.

Description

va...@google.com

created issue #1

Apr 14, 2023 05:03PM

Component used: Activity

Version used: 1.8.0-alpha03

When trying out the new `enableEdgeToEdge` method, I ran into one slightly annoying aspect.

When apps have their own theme picker for choosing dark mode and light mode, the resulting UI them (light vs dark) that the app uses may differ from the system theme, as passed down via the `Configuration`.

`enableEdgeToEdge` always looks at the system theme via the `Configuration`, so there isn't a good way to have a different source of truth for choosing whether to show a dark or light theme.

It also doesn't directly work to have an `if` statement and call `SystemBarStyle.light` or `SystemBarStyle.dark`, because those don't have the transparent behavior that `SystemBarStyle.auto` does on API 29 and above.

Maybe `enableEdgeToEdge` could take an optional lambda for `isShowingDarkTheme`, with a default implementation that uses the `Configuration`.

Comments

jb...@google.com <jb...@google.com> Apr 14, 2023 05:58PM

Assigned to ya...@google.com.

ya...@google.com <ya...@google.com> #2Apr 19, 2023 04:03AM

Reassigned to va...@google.com.

I guess technically, the ProGuard rule should be on androidx.work.NonBlockingWorker subclasses, but I'd also be okay with just not using reflection to access the Worker(Context, WorkerParamters) constructor and skipping the need for a ProGuard rule at all.

va...@google.com <va...@google.com> #3Jun 7, 2023 04:16AM

Fixed in

https://android-review.googlesource.com/c/platform/frameworks/support/+/767262

ya...@google.com <ya...@google.com> #4Jun 7, 2023 05:00AM

The fix will be available in alpha10.

Screen_recording_20230607_135618.webm

6.7 MB

Download

va...@google.com <va...@google.com> #5Jun 7, 2023 05:12AM

I tried to use the ProGuard configuration which is linked in

comment #3

in my project.
The release build fails and the following warnings are printed:

22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { NonBlockingWorker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { void internalInit(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.Worker { Worker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'

The app is opensource if you want to run the release build yourself. Here is the branch (WIP):

https://github.com/EventFahrplan/EventFahrplan/tree/workmanager
Please run: ./gradlew --info --debug aCcc34c3Release

ya...@google.com <ya...@google.com> #6Jun 7, 2023 08:30AM

Ah, that's because we have a typo in our Proguard file. Change WorkParameters to WorkerParameters.

ap...@google.com <ap...@google.com> #7Jun 15, 2023 11:37PM

Thank you for quick reply. I changed this here:

https://github.com/EventFahrplan/EventFahrplan/commit/7567331dc69a303d5c423850a97bf29005ea7b1c

The release build still fails though. Here is a part of the log output:

23:43:15.760 [ERROR] [system.err] Note: there were 11 duplicate class definitions.
23:43:15.760 [ERROR] [system.err] (

http://proguard.sourceforge.net/manual/troubleshooting.html#duplicateclass)
23:43:15.822 [QUIET] [system.out] Initializing...
23:43:15.827 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.impl.background.firebase.FirebaseJobScheduler'
23:43:15.845 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.WorkParameters'
23:43:15.857 [QUIET] [system.out] Note: the configuration refers to the unknown class 'androidx.work.impl.background.firebase.FirebaseJobScheduler'
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper: can't find referenced class sun.misc.Unsafe
23:43:16.272 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.273 [ERROR] [system.err] Warning: androidx.concurrent.futures.AbstractFuture$UnsafeAtomicHelper$1: can't find referenced class sun.misc.Unsafe
23:43:16.285 [ERROR] [system.err] Warning: androidx.work.impl.background.systemjob.SystemJobService: can't find referenced method 'android.net.Network getNetwork()' in library class android.app.job.JobParameters
23:43:16.883 [QUIET] [system.out] Note: androidx.work.impl.Schedulers: can't find dynamically referenced class androidx.work.impl.background.firebase.FirebaseJobService
23:43:16.883 [QUIET] [system.out] Note: androidx.work.impl.Schedulers: can't find dynamically referenced class androidx.work.impl.background.firebase.FirebaseJobScheduler
23:43:16.911 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.jdk8.JDK8PlatformImplementations
23:43:16.911 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.JRE8PlatformImplementations
23:43:16.912 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.jdk7.JDK7PlatformImplementations
23:43:16.912 [QUIET] [system.out] Note: kotlin.internal.PlatformImplementationsKt: can't find dynamically referenced class kotlin.internal.JRE7PlatformImplementations
23:43:16.914 [QUIET] [system.out] Note: kotlin.jvm.internal.Reflection: can't find dynamically referenced class kotlin.reflect.jvm.internal.ReflectionFactoryImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform: can't find dynamically referenced class com.android.org.conscrypt.SSLParametersImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform: can't find dynamically referenced class org.apache.harmony.xnet.provider.jsse.SSLParametersImpl
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.AndroidPlatform$CloseGuard: can't find dynamically referenced class dalvik.system.CloseGuard
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.ConscryptPlatform: can't find dynamically referenced class org.conscrypt.ConscryptEngineSocket
23:43:16.944 [QUIET] [system.out] Note: okhttp3.internal.platform.Platform: can't find dynamically referenced class sun.security.ssl.SSLContextImpl

va...@google.com <va...@google.com> Jun 15, 2023 11:42PM

Reassigned to ya...@google.com.

ya...@google.com <ya...@google.com> Jun 15, 2023 11:43PM

Marked as fixed.

pr...@google.com <pr...@google.com> #8Jun 21, 2023 08:58PM

I think your compileSdk is too low. WorkManager requires it to be 28 or higher:

https://irina-dot-devsite.googleplex.com/topic/libraries/architecture/adding-components

I'm not sure why you are running into the warnings about Unsafe, but you can try using -dontwarn sun.misc.Unsafe in your proguard file to see if it helps. We haven't observed it ourselves.

For what it's worth, one of the notes is referring to WorkParameters still - are you sure it was changed properly?