Fixed
Status Update
No update yet.
Comments
jb...@google.com
ya...@google.com
Is this fixed? I'm still seeing this issue with AGP 8.1.0-beta01 + Gradle 8.1
va...@google.com
The fix has not been landed.
ya...@google.com
Due to this bug in CI we hit configuration cache invalidation 100% of the time. Can we make sure the fix lands soon? And especially before 8.1.0 stable.
va...@google.com
I cc'ed you on the CL which should be landed this week.
ya...@google.com
Aurimas, is this 8.1 blocking for Androidx? If not, feel free to remove the "Blocking release" label.
Description
Version used: 1.8.0-alpha03
When trying out the new `enableEdgeToEdge` method, I ran into one slightly annoying aspect.
When apps have their own theme picker for choosing dark mode and light mode, the resulting UI them (light vs dark) that the app uses may differ from the system theme, as passed down via the `Configuration`.
`enableEdgeToEdge` always looks at the system theme via the `Configuration`, so there isn't a good way to have a different source of truth for choosing whether to show a dark or light theme.
It also doesn't directly work to have an `if` statement and call `SystemBarStyle.light` or `SystemBarStyle.dark`, because those don't have the transparent behavior that `SystemBarStyle.auto` does on API 29 and above.
Maybe `enableEdgeToEdge` could take an optional lambda for `isShowingDarkTheme`, with a default implementation that uses the `Configuration`.