Fixed

Bug

Gradle 8.1 configuration cache breakages

Status Update

No update yet.

Description

au...@google.com

created issue #1

Apr 18, 2023 08:46PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

check out androidx
apply https://android-review.git.corp.google.com/q/topic:%22gradle-8.1%22
./busytown/androidx_device_tests.sh

Expected

Our build is run twice (for up to dateness validation). Second run uses configuration cache

Actual

Second build does not use configuration cache, it is dropped due to

Calculating task graph as configuration cache cannot be reused because the file system entry '../../out/.gradle/.android/analytics.settings' has been created.

Studio Build:
Version of Gradle Plugin: 8.1.0-alpha11
Version of Gradle: 8.1
Version of Java: 17
OS: linux

Comments

bi...@google.com <bi...@google.com> Apr 18, 2023 08:47PM

Assigned to bi...@google.com.

jv...@google.com <jv...@google.com> Apr 19, 2023 05:28AM

Reassigned to an...@google.com.

ga...@google.com <ga...@google.com> Apr 19, 2023 08:16AM

Reassigned to bi...@google.com.

au...@google.com <au...@google.com> #2May 1, 2023 04:43PM

Thanks for trying out Room KMP! This looks like an issue with Android 9+ and armv7 and the way we compile sqlite3.c, specifically linking to the atomic library in C. We'll try to get this fix as soon as possible.

bi...@google.com <bi...@google.com> #3May 1, 2023 06:13PM

Very related: https://sqlite.org/forum/info/aa703e86823efca3, as suspected seems like a linking issue.

au...@google.com <au...@google.com> #4May 1, 2023 06:15PM

Facing the same issue here, surprisingly using the AndroidSQLiteDriver instead of the bundled one seems to work fine. So for now, others facing the crash can fix it by using the AndroidSQLiteDriver instead of the bundled one

bi...@google.com <bi...@google.com> #5May 1, 2023 06:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit cf121571aac008a756b64cda13f76ae4db3e85a6
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed May 29 11:14:42 2024

Link to Android's atomic lib in bundled SQLite

Fix Bundled SQLite loading for devices with older ARM architecture by linking to Android's atomic library instead of relying on Clang's extension (c_atomic) or GCC's built-ins as used in sqlite3.c.

Also add support for passing linker args to androidx's native compilation infra.

See also discussion in

https://sqlite.org/forum/forumpost/792d76a592608d8f

Bug: 341639198
Test: Locally tested via BundledSQLiteDriverTest in a Nexus 5 on API 23
Change-Id: Ia818b7c4f1a990a1b5e35f4c7a3c89694aee0503

M buildSrc/private/src/main/kotlin/androidx/build/clang/ClangSharedLibraryTask.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/KonanBuildService.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/MultiTargetNativeCompilation.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/NativeTargetCompilation.kt
M sqlite/sqlite-bundled/build.gradle

https://android-review.googlesource.com/3108157

ga...@google.com <ga...@google.com> #6May 23, 2023 05:51PM

Hello, even if I updated to version androidx.sqlite:sqlite-bundled:2.5.0-alpha04 I just received a crash on a nexus 5X with android 8.1.0 and another one on Redmi Note 11 Pro with android 13.
I'm using androidx.room:room-runtime-android:2.7.0-alpha01.

This is the log:
Fatal Exception: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/base.apk"],nativeLibraryDirectories=[/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
at java.lang.System.loadLibrary(System.java:1657)
at androidx.sqlite.driver.bundled.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.android.kt:1)
at androidx.sqlite.driver.bundled.BundledSQLiteDriver.<clinit>(BundledSQLiteDriver.jvmAndroid.kt:1)

Thank you!

bi...@google.com <bi...@google.com> #7May 23, 2023 08:55PM

Marked as fixed.

Can you try using androidx.room:room-runtime-android:2.7.0-alpha04 and confirm if the issue is still present?

sp...@google.com <sp...@google.com> #8Jun 16, 2023 07:17PM

Status: Assigned (reopened)

I will let you know, in alternative can I use AndroidSQLiteDriver instead of the bundled one just for the android implementation?

sp...@google.com <sp...@google.com> #9Jun 16, 2023 07:54PM

Ideally you could use AndroidSQLiteDriver but Room has a bug with the AndroidSQLiteDriver that is fixed in version 2.7.0-alpha05 that will be released in July 10 so I recommend that if you do switch to using AndroidSQLiteDriver wait for the alpha05 release.

xa...@google.com <xa...@google.com> #10Jun 20, 2023 02:58PM

I believe this error still exists.

I just received two errors from Crashlytics using androidx.sqlite:sqlite-bundled version 2.5.0-alpha06 and BundledSQLiteDriver for both Android and iOS.

Fatal Exception: java.lang.UnsatisfiedLinkError
dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"

And the exception is in .setDriver(BundledSQLiteDriver())

Both crashes were from a Nexus 5X running Android 8.1.0

I would say it is the same exception as in

comment #6

sp...@google.com <sp...@google.com> #11Jun 20, 2023 04:04PM

Same crash on Nexus 5X running Android 8.1.0 on androidx.sqlite:sqlite-bundled version 2.5.0-alpha10 with room version 2.7.0-alpha10.

sp...@google.com <sp...@google.com> #12Jul 12, 2023 06:09PM

Reassigned to sa...@google.com.

Same crash on Pixel 6 Pro(android12),Nexus 5X(android8.1) on androidx.sqlite:sqlite-bundled version 2.5.0-alpha11 with room version 2.7.0-alpha11.

sp...@google.com <sp...@google.com> #13Jul 21, 2023 04:49AM

Same crash on Android 12, Pixel 6 Pro.
androidx.sqlite:sqlite-bundled version 2.5.0-alpha11 with room version 2.7.0-alpha11

au...@google.com <au...@google.com> #14Aug 10, 2023 11:08PM

Reassigned to bi...@google.com.

For those experiencing this issue, can you provide any more detail: stacktrace, bug report, trends (specific API versions, specific manufacturer)?

Usually with UnsatisfiedLinkError there is more in the logs / error mentioning why the native library couldn't be used, specifically the missing symbol. I have so far validated we are linking against the right atomic library in the NDK, so I suspect it must be another symbol.

au...@google.com <au...@google.com> #15Aug 10, 2023 11:27PM

Same crash on Pixel 6 pro

androidx-room = "2.7.0-alpha11"

androidx-sqlite = "2.5.0-alpha11"

Attached a stack trace

ga...@google.com <ga...@google.com> #16Aug 11, 2023 01:57PM

Hi, we released a app yesterday and we are facing the same issue with the same stack trace of

https://issuetracker.google.com/issues/341639198#comment15

Does anyone knows if it's safe to use AndroidSQLiteDriver for android as a backup plan?

We also released the iOS app some weeks ago and until know we didn't catch any issue related to this.

bi...@google.com <bi...@google.com> #17Aug 11, 2023 11:31PM

For the stacktrace in comment#15 its as if the JNI lib was not packaged with the APK, can you confirm if the APK has the native libraries? They should be located in jni/<abi>/libsqliteJni.so

Message last modified on Aug 11, 2023 11:35PM

ga...@google.com <ga...@google.com> #18Aug 15, 2023 05:25PM

Hi, thanks for the reply we don't have the JNI lib jni/<abi>/libsqliteJni.so
We have the structure like in the screenshoot

je...@google.com <je...@google.com> #19Aug 29, 2023 09:16PM

Facing the same

issue 2

.7.0-alpha12

je...@google.com <je...@google.com> #20Aug 29, 2023 10:04PM

Also interesting, that non-incremental log from Comment #14 ( https://android-build.corp.google.com/artifact/pending/P60996184/androidx_compose_multiplatform/latest/view/logs%2Fbuild_error.log ) says:

'../../out/.gradle/.android/analytics.settings' has been created

rather than just modified

bi...@google.com <bi...@google.com> #21Aug 29, 2023 10:10PM

In terms of #20, I think that is expected because we normally see config cache miss if a file is created during configuration. However, if a file get modified, I assume it would say xxx has been modified.

je...@google.com <je...@google.com> #22Aug 30, 2023 08:31PM

I haven't managed to reproduce this on my computer yet but I reproduced it again on the build server at aosp/2731437 :

https://android-build.corp.google.com/artifact/pending/P61949730/androidx_compose_multiplatform/latest/view/logs%2Fbuild_error.log

This debugging change says that:

analytics.settings was written at:

2023-08-30 20:08:54.977482090 +0000

first Gradle start at Wed Aug 30 20:03:28 UTC 2023

first Gradle end at Wed Aug 30 20:09:35 UTC 2023

It looks like something in the first build wrote this file somewhat near the end of the build

Specifically, about 5m26s - 5m27s after the start of the build and 40s-41s before the end of the build

Resulting scan:

https://ge.androidx.dev/s/ijhfuuvrsdbkg

I see a few tasks that started in this build scan at approximately 5m26s, mostly lint-related.

I'll see if I can get more details

Message last modified on Aug 30, 2023 08:39PM

je...@google.com <je...@google.com> #23Aug 31, 2023 09:51PM

I checked some timestamps again in aosp/2731437

Gradle started at 21:01:18 UTC 2023

Gradle completed at 21:07:21 UTC 2023

analytics.settings created at 21:05:35.748195543

4m17s after Gradle started

1m46s before Gradle ended

Uploaded the scan to https://ge.androidx.dev/s/zsuj6it4dvngu/timeline?end=1693516039451&page=39&start=1693515904743

I see a few tasks running in that scan around 4m17s, mostly but not exclusively lint

je...@google.com <je...@google.com> #24Aug 31, 2023 09:51PM

I just tried this command:

  OUT_DIR=../../out DIST_DIR=../../out/dist ./busytown/androidx_compose_multiplatform.sh

and found that that reproduced the error on my computer. Maybe we can simplify it from there

sp...@google.com <sp...@google.com> #25Aug 31, 2023 10:37PM

I see a few tasks running in that scan around 4m17s, mostly but not exclusively lint

I took a look at my previous lint fix after seeing this.

I think the problem might be that LintClient.isGradle might not always be true when running the lint tasks, in which case this fix doesn't work.

LintClient.isGradle should be true when running lint tasks from Gradle because we invoke lint with --client-id gradle, but when I run grep -r "client=\"" on the AndroidX codebase, I see a mix of client="gradle" and client="cli", which suggests to me that the client id is being reset in some cases.

je...@google.com <je...@google.com> #26Sep 1, 2023 06:11PM

I ran this command:

  rm ../../out -rf && OUT_DIR=../../out DIST_DIR=../../out/dist ./gradlew lintAnalyzeDebug -Pandroidx.verifyUpToDate

and it created ../../out/.gradle/.android/analytics.settings

but when I ran this command

  rm ../../out -rf && OUT_DIR=../../out DIST_DIR=../../out/dist ./gradlew lintAnalyzeDebug -Pandroidx.verifyUpToDate --max-workers 1

it didn't create ../../out/.gradle/.android/analytics.settings

so it could be that reproducing the error requires running certain tasks at the same time

je...@google.com <je...@google.com> #27Sep 1, 2023 06:44PM

Combining Comment #25 and (sometimes lint reports being the wrong client) and Comment #26 (reproducing the issue seems to require parallelism), perhaps for the lint client to be wrong requires multiple tasks running at once.

I think lint runs inside the Gradle Daemon JVM process - is that right?

I notice LintClient.kt mentions “@JvmStatic lateinit var clientName: String”. I think that means multiple lint clients might be able to overwrite each others’ values?

Maybe I can figure out which tasks set the lint client to something else

bi...@google.com <bi...@google.com> Sep 1, 2023 06:59PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #28Sep 1, 2023 07:22PM

Thanks for the insights Jeff!

I suspect the root cause is that lint itself sets this value multiple times from a single invocation. See here and here.

I'll write a fix for this.

sp...@google.com <sp...@google.com> #29Sep 7, 2023 04:10PM

I'll write a fix for this.

The fix is here. It will be in AGP 8.3.0-alpha03 and 8.2.0-beta04.

je...@google.com <je...@google.com> #30Sep 7, 2023 04:41PM

Thanks!

I investigated a little bit more into the plausibility of our guess (parallel lint invocations causing incorrect client) and it seems to be holding up:

1: I notice that aosp/2724176 changes some clients from "cli" to "gradle" for example https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2724176/5/camera/integration-tests/coretestapp/lint-baseline.xml and also changes some clients from "gradle" to "cli" for example https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2724176/5/compose/ui/ui/lint-baseline.xml

2: I regenerated all of the lint baselines via echo | tee find -name lint-baseline.xml && ./gradlew updateLintBaseline --max-workers=1 and found that it put 'client="gradle"' into the resulting files

I'll check again later after updating to the corresponding AGP

Message last modified on Sep 7, 2023 07:04PM

sp...@google.com <sp...@google.com> #31Sep 8, 2023 04:49PM

Reassigned to bi...@google.com.

Thanks again Jeff!

Reassigning back to Bingran assuming the lint issue has been resolved.

In our integration tests, there are cases(e.g. AnalyticsConfigurationCachingTest) we need to create this file, therefore you would get config cache miss. So it is intended that we still have an entry in ConfigurationCacheReportChecker.

Unfortunately, yes, this change makes AGP's check for the existence of the file compatible with configuration caching, but AnalyticsSettings is still interacting with the file in a way that is not compatible with configuration caching.

sp...@google.com <sp...@google.com> Sep 11, 2023 05:05PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #32Sep 12, 2023 08:56PM

Marked as fixed.

This has been fixed here. Fix will be in AGP 8.3.0-alpha04.

an...@google.com <an...@google.com> #33Sep 13, 2023 06:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Hedgehog | 2023.1.1 Beta 4
Android Gradle Plugin 8.2.0-beta04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #34Sep 15, 2023 04:16PM

The fixes for this issue are now also available in:

Android Studio Iguana | 2023.2.1 Canary 4
Android Gradle Plugin 8.3.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

jf...@block.xyz <jf...@block.xyz> #35Sep 18, 2023 01:59PM

In Gradle 8.3 we are ignoring this file with the following in gradle.properties:

org.gradle.configuration-cache.inputs.unsafe.ignore.file-system-checks=**/.gradle/.android/analytics.settings

However, the AnalyticsService still breaks configuration on demand for some people:

> Failed to apply plugin 'com.android.internal.library'.
   > Accessing GradleBuildProject.Builder through AnalyticsConfiguratorService is not allowed after AnalyticsService is created.

We've found that setting "hasOptedIn":false," in ~.gradle/.android/analytics.settings fixes the issue.

sp...@google.com <sp...@google.com> #36Sep 18, 2023 03:47PM

Re: #35, that looks like Issue 270731522

mf...@gmail.com <mf...@gmail.com> #37Oct 1, 2023 10:24AM

والله ودي اخدمك بعيوني يالي اتفقتو على شخصي..الدنيا زايله وطريق ممر
وجيهكم خلوني في حالي ..ماهو مقر.طالب

mf...@gmail.com <mf...@gmail.com> #38Oct 1, 2023 10:25AM

والله ماني سهل فهمت الجوال من لقلكم

tk...@gmail.com <tk...@gmail.com> #39May 7, 2024 04:52PM

Substack break down be good if any issues were 2 arise that it was automatically corrected

Issue 278767328

Description

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Expected

Actual

Issue summary

Comments

bi...@google.com <bi...@google.com> Apr 18, 2023 08:47PM

jv...@google.com <jv...@google.com> Apr 19, 2023 05:28AM

ga...@google.com <ga...@google.com> Apr 19, 2023 08:16AM

au...@google.com <au...@google.com> #2May 1, 2023 04:43PM

bi...@google.com <bi...@google.com> #3May 1, 2023 06:13PM

au...@google.com <au...@google.com> #4May 1, 2023 06:15PM

bi...@google.com <bi...@google.com> #5May 1, 2023 06:17PM

ga...@google.com <ga...@google.com> #6May 23, 2023 05:51PM

bi...@google.com <bi...@google.com> #7May 23, 2023 08:55PM

sp...@google.com <sp...@google.com> #8Jun 16, 2023 07:17PM

sp...@google.com <sp...@google.com> #9Jun 16, 2023 07:54PM

xa...@google.com <xa...@google.com> #10Jun 20, 2023 02:58PM

sp...@google.com <sp...@google.com> #11Jun 20, 2023 04:04PM

sp...@google.com <sp...@google.com> #12Jul 12, 2023 06:09PM

sp...@google.com <sp...@google.com> #13Jul 21, 2023 04:49AM

au...@google.com <au...@google.com> #14Aug 10, 2023 11:08PM

au...@google.com <au...@google.com> #15Aug 10, 2023 11:27PM

ga...@google.com <ga...@google.com> #16Aug 11, 2023 01:57PM

bi...@google.com <bi...@google.com> #17Aug 11, 2023 11:31PM

ga...@google.com <ga...@google.com> #18Aug 15, 2023 05:25PM

je...@google.com <je...@google.com> #19Aug 29, 2023 09:16PM

je...@google.com <je...@google.com> #20Aug 29, 2023 10:04PM

bi...@google.com <bi...@google.com> #21Aug 29, 2023 10:10PM

je...@google.com <je...@google.com> #22Aug 30, 2023 08:31PM

je...@google.com <je...@google.com> #23Aug 31, 2023 09:51PM

je...@google.com <je...@google.com> #24Aug 31, 2023 09:51PM

sp...@google.com <sp...@google.com> #25Aug 31, 2023 10:37PM

je...@google.com <je...@google.com> #26Sep 1, 2023 06:11PM

je...@google.com <je...@google.com> #27Sep 1, 2023 06:44PM

bi...@google.com <bi...@google.com> Sep 1, 2023 06:59PM

sp...@google.com <sp...@google.com> #28Sep 1, 2023 07:22PM

sp...@google.com <sp...@google.com> #29Sep 7, 2023 04:10PM

je...@google.com <je...@google.com> #30Sep 7, 2023 04:41PM

sp...@google.com <sp...@google.com> #31Sep 8, 2023 04:49PM

sp...@google.com <sp...@google.com> Sep 11, 2023 05:05PM

sp...@google.com <sp...@google.com> #32Sep 12, 2023 08:56PM

an...@google.com <an...@google.com> #33Sep 13, 2023 06:59PM

an...@google.com <an...@google.com> #34Sep 15, 2023 04:16PM

jf...@block.xyz <jf...@block.xyz> #35Sep 18, 2023 01:59PM

sp...@google.com <sp...@google.com> #36Sep 18, 2023 03:47PM

mf...@gmail.com <mf...@gmail.com> #37Oct 1, 2023 10:24AM

mf...@gmail.com <mf...@gmail.com> #38Oct 1, 2023 10:25AM

tk...@gmail.com <tk...@gmail.com> #39May 7, 2024 04:52PM

Add comment

Issue metadata