Fixed

Bug

Gradle 8.1 configuration cache breakages

Status Update

No update yet.

Description

au...@google.com

created issue #1

Apr 18, 2023 08:46PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

check out androidx
apply https://android-review.git.corp.google.com/q/topic:%22gradle-8.1%22
./busytown/androidx_device_tests.sh

Expected

Our build is run twice (for up to dateness validation). Second run uses configuration cache

Actual

Second build does not use configuration cache, it is dropped due to

Calculating task graph as configuration cache cannot be reused because the file system entry '../../out/.gradle/.android/analytics.settings' has been created.

Studio Build:
Version of Gradle Plugin: 8.1.0-alpha11
Version of Gradle: 8.1
Version of Java: 17
OS: linux

Comments

bi...@google.com <bi...@google.com> Apr 18, 2023 08:47PM

Assigned to bi...@google.com.

jv...@google.com <jv...@google.com> Apr 19, 2023 05:28AM

Reassigned to an...@google.com.

ga...@google.com <ga...@google.com> Apr 19, 2023 08:16AM

Reassigned to bi...@google.com.

au...@google.com <au...@google.com> #2May 1, 2023 04:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d0a10be065a3a629e3835f28d35804c91d8d2e4d
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1427352

bi...@google.com <bi...@google.com> #3May 1, 2023 06:13PM

We've updated the error message to make it more clear what destination you're currently on - this will help you determine if your call to setGraph() hasn't happened yet (you have a null current destination) or if you've popped to another destination unexpectedly.

au...@google.com <au...@google.com> #4May 1, 2023 06:15PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 6ada6bd039f4a28d2760f4912093abc60ab54d84
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436733

bi...@google.com <bi...@google.com> #5May 1, 2023 06:17PM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit e5780347bfba28e4a500bd964d273c282c12dceb
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436737

ga...@google.com <ga...@google.com> #6May 23, 2023 05:51PM

Project: platform/frameworks/support
Branch: snap-temp-L46100000699831674

commit 7ab7f8b1967945ba0d506120dbc070ecbfb37c13
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436741

bi...@google.com <bi...@google.com> #7May 23, 2023 08:55PM

Marked as fixed.

Project: platform/frameworks/support
Branch: snap-temp-L91000000699844097

commit 4101ca222554fdfae678ff1e6e47b1a4ab319a56
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436542

sp...@google.com <sp...@google.com> #8Jun 16, 2023 07:17PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: snap-temp-L34200000699848945

commit 0da3ed71fa5545646d44fb44219b31e7e5621f8f
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436745

sp...@google.com <sp...@google.com> #9Jun 16, 2023 07:54PM

Project: platform/frameworks/support
Branch: snap-temp-L04700000699849955

commit 12b13608ec1155b5780fe44f5ab07cdc93c5ba90
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436750

xa...@google.com <xa...@google.com> #10Jun 20, 2023 02:58PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699869549

commit 7204d04ad74baf9816389e27778266391fbd79a5
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436913

sp...@google.com <sp...@google.com> #11Jun 20, 2023 04:04PM

Project: platform/frameworks/support
Branch: snap-temp-L31300000699869852

commit 398a1fe7bb7792589189574aec5f6e77bb749229
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436917

sp...@google.com <sp...@google.com> #12Jul 12, 2023 06:09PM

Reassigned to sa...@google.com.

Project: platform/frameworks/support
Branch: snap-temp-L53700000699921463

commit 31027c16ff20b10e78093f8de205c81fc49dfc92
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436920

sp...@google.com <sp...@google.com> #13Jul 21, 2023 04:49AM

Project: platform/frameworks/support
Branch: snap-temp-L25200000699921867

commit 63e58ff4f522eb70dec6c0749679fb6b963698d8
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436924

au...@google.com <au...@google.com> #14Aug 10, 2023 11:08PM

Reassigned to bi...@google.com.

Project: platform/frameworks/support
Branch: snap-temp-L07700000699933785

commit 56fe0d47de20fb430c4280332a20eb96076dd44b
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436929

au...@google.com <au...@google.com> #15Aug 10, 2023 11:27PM

getting this error even after ensuring we are setting graph before using it..
Caused by java.lang.IllegalArgumentException
No destination with ID 2131427956 is on the NavController's back stack in HiltNavGraphViewModelLazy.kt:49) , we are using androidx.hilt:hilt-navigation-fragment:1.0.0

androidx.navigation.NavController.getBackStackEntry (NavController.kt:2204)
androidx.hilt.navigation.fragment.HiltNavGraphViewModelLazyKt$hiltNavGraphViewModels$backStackEntry$2.invoke (HiltNavGraphViewModelLazyKt.java:49)
$special$$inlined$hiltNavGraphViewModels$4.invoke (HiltNavGraphViewModelLazy.kt:49)

is there any way to prevent it?

ga...@google.com <ga...@google.com> #16Aug 11, 2023 01:57PM

Could we further improve this by indicating the name of the destination instead of just the ID number?

bi...@google.com <bi...@google.com> #17Aug 11, 2023 11:31PM

If you use a resource to provide the name it will already be displayed. Along with any route or label you may have added.

Message last modified on Aug 11, 2023 11:35PM

ga...@google.com <ga...@google.com> #18Aug 15, 2023 05:25PM

We are also getting this error even after ensuring we are setting the graph before using .popBackStack().

Is there any way to safeguard against this? I am not able to reproduce the error myself, but get a lot of errors show up in Crashlytics

je...@google.com <je...@google.com> #19Aug 29, 2023 09:16PM

I have the same problem

je...@google.com <je...@google.com> #20Aug 29, 2023 10:04PM

Same here. It is not fixed. Can you reopen and look again?

bi...@google.com <bi...@google.com> #21Aug 29, 2023 10:10PM

Same problem here

je...@google.com <je...@google.com> #22Aug 30, 2023 08:31PM

Same problem here

Message last modified on Aug 30, 2023 08:39PM

je...@google.com <je...@google.com> #23Aug 31, 2023 09:51PM

Same problem here

je...@google.com <je...@google.com> #24Aug 31, 2023 09:51PM

Same problem here, currently using version 2.7.7

sp...@google.com <sp...@google.com> #25Aug 31, 2023 10:37PM

same problem here

je...@google.com <je...@google.com> #26Sep 1, 2023 06:11PM

I ran this command:

  rm ../../out -rf && OUT_DIR=../../out DIST_DIR=../../out/dist ./gradlew lintAnalyzeDebug -Pandroidx.verifyUpToDate

and it created ../../out/.gradle/.android/analytics.settings

but when I ran this command

  rm ../../out -rf && OUT_DIR=../../out DIST_DIR=../../out/dist ./gradlew lintAnalyzeDebug -Pandroidx.verifyUpToDate --max-workers 1

it didn't create ../../out/.gradle/.android/analytics.settings

so it could be that reproducing the error requires running certain tasks at the same time

je...@google.com <je...@google.com> #27Sep 1, 2023 06:44PM

Combining Comment #25 and (sometimes lint reports being the wrong client) and Comment #26 (reproducing the issue seems to require parallelism), perhaps for the lint client to be wrong requires multiple tasks running at once.

I think lint runs inside the Gradle Daemon JVM process - is that right?

I notice LintClient.kt mentions “@JvmStatic lateinit var clientName: String”. I think that means multiple lint clients might be able to overwrite each others’ values?

Maybe I can figure out which tasks set the lint client to something else

bi...@google.com <bi...@google.com> Sep 1, 2023 06:59PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #28Sep 1, 2023 07:22PM

Thanks for the insights Jeff!

I suspect the root cause is that lint itself sets this value multiple times from a single invocation. See here and here.

I'll write a fix for this.

sp...@google.com <sp...@google.com> #29Sep 7, 2023 04:10PM

I'll write a fix for this.

The fix is here. It will be in AGP 8.3.0-alpha03 and 8.2.0-beta04.

je...@google.com <je...@google.com> #30Sep 7, 2023 04:41PM

Thanks!

I investigated a little bit more into the plausibility of our guess (parallel lint invocations causing incorrect client) and it seems to be holding up:

1: I notice that aosp/2724176 changes some clients from "cli" to "gradle" for example https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2724176/5/camera/integration-tests/coretestapp/lint-baseline.xml and also changes some clients from "gradle" to "cli" for example https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2724176/5/compose/ui/ui/lint-baseline.xml

2: I regenerated all of the lint baselines via echo | tee find -name lint-baseline.xml && ./gradlew updateLintBaseline --max-workers=1 and found that it put 'client="gradle"' into the resulting files

I'll check again later after updating to the corresponding AGP

Message last modified on Sep 7, 2023 07:04PM

sp...@google.com <sp...@google.com> #31Sep 8, 2023 04:49PM

Reassigned to bi...@google.com.

Thanks again Jeff!

Reassigning back to Bingran assuming the lint issue has been resolved.

In our integration tests, there are cases(e.g. AnalyticsConfigurationCachingTest) we need to create this file, therefore you would get config cache miss. So it is intended that we still have an entry in ConfigurationCacheReportChecker.

Unfortunately, yes, this change makes AGP's check for the existence of the file compatible with configuration caching, but AnalyticsSettings is still interacting with the file in a way that is not compatible with configuration caching.

sp...@google.com <sp...@google.com> Sep 11, 2023 05:05PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #32Sep 12, 2023 08:56PM

Marked as fixed.

This has been fixed here. Fix will be in AGP 8.3.0-alpha04.

an...@google.com <an...@google.com> #33Sep 13, 2023 06:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Hedgehog | 2023.1.1 Beta 4
Android Gradle Plugin 8.2.0-beta04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #34Sep 15, 2023 04:16PM

The fixes for this issue are now also available in:

Android Studio Iguana | 2023.2.1 Canary 4
Android Gradle Plugin 8.3.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

jf...@block.xyz <jf...@block.xyz> #35Sep 18, 2023 01:59PM

In Gradle 8.3 we are ignoring this file with the following in gradle.properties:

org.gradle.configuration-cache.inputs.unsafe.ignore.file-system-checks=**/.gradle/.android/analytics.settings

However, the AnalyticsService still breaks configuration on demand for some people:

> Failed to apply plugin 'com.android.internal.library'.
   > Accessing GradleBuildProject.Builder through AnalyticsConfiguratorService is not allowed after AnalyticsService is created.

We've found that setting "hasOptedIn":false," in ~.gradle/.android/analytics.settings fixes the issue.

sp...@google.com <sp...@google.com> #36Sep 18, 2023 03:47PM

Re: #35, that looks like Issue 270731522

mf...@gmail.com <mf...@gmail.com> #37Oct 1, 2023 10:24AM

والله ودي اخدمك بعيوني يالي اتفقتو على شخصي..الدنيا زايله وطريق ممر
وجيهكم خلوني في حالي ..ماهو مقر.طالب

mf...@gmail.com <mf...@gmail.com> #38Oct 1, 2023 10:25AM

والله ماني سهل فهمت الجوال من لقلكم

tk...@gmail.com <tk...@gmail.com> #39May 7, 2024 04:52PM

Substack break down be good if any issues were 2 arise that it was automatically corrected

Issue 278767328

Description

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Expected

Actual

Issue summary

Comments

bi...@google.com <bi...@google.com> Apr 18, 2023 08:47PM

jv...@google.com <jv...@google.com> Apr 19, 2023 05:28AM

ga...@google.com <ga...@google.com> Apr 19, 2023 08:16AM

au...@google.com <au...@google.com> #2May 1, 2023 04:43PM

bi...@google.com <bi...@google.com> #3May 1, 2023 06:13PM

au...@google.com <au...@google.com> #4May 1, 2023 06:15PM

bi...@google.com <bi...@google.com> #5May 1, 2023 06:17PM

ga...@google.com <ga...@google.com> #6May 23, 2023 05:51PM

bi...@google.com <bi...@google.com> #7May 23, 2023 08:55PM

sp...@google.com <sp...@google.com> #8Jun 16, 2023 07:17PM

sp...@google.com <sp...@google.com> #9Jun 16, 2023 07:54PM

xa...@google.com <xa...@google.com> #10Jun 20, 2023 02:58PM

sp...@google.com <sp...@google.com> #11Jun 20, 2023 04:04PM

sp...@google.com <sp...@google.com> #12Jul 12, 2023 06:09PM

sp...@google.com <sp...@google.com> #13Jul 21, 2023 04:49AM

au...@google.com <au...@google.com> #14Aug 10, 2023 11:08PM

au...@google.com <au...@google.com> #15Aug 10, 2023 11:27PM

ga...@google.com <ga...@google.com> #16Aug 11, 2023 01:57PM

bi...@google.com <bi...@google.com> #17Aug 11, 2023 11:31PM

ga...@google.com <ga...@google.com> #18Aug 15, 2023 05:25PM

je...@google.com <je...@google.com> #19Aug 29, 2023 09:16PM

je...@google.com <je...@google.com> #20Aug 29, 2023 10:04PM

bi...@google.com <bi...@google.com> #21Aug 29, 2023 10:10PM

je...@google.com <je...@google.com> #22Aug 30, 2023 08:31PM

je...@google.com <je...@google.com> #23Aug 31, 2023 09:51PM

je...@google.com <je...@google.com> #24Aug 31, 2023 09:51PM

sp...@google.com <sp...@google.com> #25Aug 31, 2023 10:37PM

je...@google.com <je...@google.com> #26Sep 1, 2023 06:11PM

je...@google.com <je...@google.com> #27Sep 1, 2023 06:44PM

bi...@google.com <bi...@google.com> Sep 1, 2023 06:59PM

sp...@google.com <sp...@google.com> #28Sep 1, 2023 07:22PM

sp...@google.com <sp...@google.com> #29Sep 7, 2023 04:10PM

je...@google.com <je...@google.com> #30Sep 7, 2023 04:41PM

sp...@google.com <sp...@google.com> #31Sep 8, 2023 04:49PM

sp...@google.com <sp...@google.com> Sep 11, 2023 05:05PM

sp...@google.com <sp...@google.com> #32Sep 12, 2023 08:56PM

an...@google.com <an...@google.com> #33Sep 13, 2023 06:59PM

an...@google.com <an...@google.com> #34Sep 15, 2023 04:16PM

jf...@block.xyz <jf...@block.xyz> #35Sep 18, 2023 01:59PM

sp...@google.com <sp...@google.com> #36Sep 18, 2023 03:47PM

mf...@gmail.com <mf...@gmail.com> #37Oct 1, 2023 10:24AM

mf...@gmail.com <mf...@gmail.com> #38Oct 1, 2023 10:25AM

tk...@gmail.com <tk...@gmail.com> #39May 7, 2024 04:52PM

Add comment

Issue metadata