Cannot read orientation for portrait WEBP from Samsung Galaxy S22 [281638358]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 9, 2023 06:07PM

Component used: AndroidX ExifInterface Version used: 1.3.6 Devices/Android versions reproduced on: Samsung Galaxy S22 Ultra, Android 13, One UI 5.1

When reporting bugs, please always include:

A full bug report as an attachment, captured during or shortly after experiencing the issue.
Reproduction steps, being as specific as possible.
How reproducible the issue is on the affected device.
If known, how reproducible the issue is on other devices and OS versions.

Where possible, please also provide:

A sample project that reproduces the issue.
A screenrecord or screenshots showing the issue.

I attached an image that is experiencing this issue. It was captured in portrait mode and should show that in EXIF data that it was rotated 90 degrees. It appears correctly in MacOS Preview and on this online EXIF data site: https://jimpl.com/results/FWuAnboJWW1vdDpRmeUKsccb?target=exif

I added this to dependencies:

    implementation "androidx.exifinterface:exifinterface:1.3.6"

I added this to code:

                val file = context.filesDir.resolve("676x380.webp")
                URL(imageUrl).openStream().use { input ->
                    FileOutputStream(file).use { output ->
                        input.copyTo(output)
                        val exif = ExifInterface(file.path)
                        val orientation: Int =
                            exif.getAttributeInt(
                                ExifInterface.TAG_ORIENTATION,
                                ExifInterface.ORIENTATION_UNDEFINED
                            )
                        Timber.d("Orientation is $orientation")
                        Timber.d("Flipped: ${exif.isFlipped}")
                        Timber.d("Rotation degrees: ${exif.rotationDegrees}")
                    }
                }

This is the result:

D  Orientation is 0
D  Flipped: false
D  Rotation degrees: 0

676x380.webp

114 KB

View

Download

Comments

[Deleted User] <[Deleted User]> #2May 9, 2023 07:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on May 9, 2023 07:04PM

mi...@google.com <mi...@google.com> May 11, 2023 09:01AM

Reassigned to ib...@google.com.

[Deleted User] <[Deleted User]> #3May 12, 2023 06:33PM

For context, I found this because I got a bug report about a similar issue with an upside down photo on a Samsung Galaxy S10 and managed to reproduce the problem as a sideways WEBP on an S22 Ultra. I can supply more pictures from different Samsung models exhibiting this same problem if that would be useful.

Message last modified on May 12, 2023 06:33PM

[Deleted User] <[Deleted User]> #4Sep 14, 2023 04:02PM

Will anyone please take a look at this bug? It appears on many, very common devices and results in mis-rotated images.

ib...@google.com <ib...@google.com> Nov 24, 2023 10:14AM

Reassigned to an...@google.com.

la...@gmail.com <la...@gmail.com> #5Dec 22, 2023 04:53PM

Hi,

I can confirm there is an issue with the WebP exif reading implementation. I ran into the same issue when retrieving WebP images from the Amazon's Serverless Image Handler. Initially I thought it was a bug in the library I'm using (Coil) but found out it wasn't the case.

I have a bugfix available for the issue and am preparing a PR (that will be submitted via Gerrit).

Validated with my own images (a yellow sticky note captured at all 4 orientations) + the one from the google repo + the one from the topic starter.

Note: The bottom left image is a google webp without exif, the bottom right image is a google webp with exif

Note 2: It's also broken in Chrome & Firefox but works correctly on Safari/Finder on MacOS. I might submit bugfixes for those too.

Message last modified on Dec 22, 2023 05:00PM

google-exif-interface.png

2.9 MB

View

Download

laurence-exif-interface.png

2.8 MB

View

Download

la...@gmail.com <la...@gmail.com> #6Dec 22, 2023 09:21PM

Comment has been deleted.

Message last modified on Dec 23, 2023 01:43AM

la...@gmail.com <la...@gmail.com> #7Dec 23, 2023 01:45AM

PR here: https://android-review.googlesource.com/c/platform/frameworks/support/+/2889627

ib...@google.com <ib...@google.com> #8Jan 2, 2024 11:01AM

Thanks for the detailed investigation! I've replied on the PR with more details - but I'm not sure this image is a valid WebP.

ap...@google.com <ap...@google.com> #9Feb 7, 2024 10:00AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 161d43d41357f5d34fe7907c82ed9fca0b04d57a
Author: Laurence Muller <laurence.muller@gmail.com>
Date: Fri Dec 22 14:38:22 2023

Fix attribute reader for WebP images with Exif App1 Sections

The current attribute reader for WebP images fails to read the attributes if the Exif metadata contains an Exif App1 Section. The reason is that the byte-order is specified after the Exif App1 Section marker in the Exif payload. This patch will check if the Exif App1 section is present and correct the payload accordingly. This will allow it to read the Exif metadata (such as image orientation) correctly.

Test: Added a new image to cover this use case with a test. Run the instrument test using: ./gradlew :exifinterface:exifinterface:connectedAndroidTest

Fixes:

b/281638358

Change-Id: Idbb14e9fbcb038616ce650da03ed1d7eb9f997a5

M exifinterface/exifinterface/src/androidTest/java/androidx/exifinterface/media/ExifInterfaceTest.java
A exifinterface/exifinterface/src/androidTest/res/raw/invalid_webp_with_jpeg_app1_marker.webp
M exifinterface/exifinterface/src/androidTest/res/values/arrays.xml
M exifinterface/exifinterface/src/main/java/androidx/exifinterface/media/ExifInterface.java

https://android-review.googlesource.com/2889627

ib...@google.com <ib...@google.com> Feb 7, 2024 10:35AM

Reassigned to la...@gmail.com.

la...@gmail.com <la...@gmail.com> #10Feb 13, 2024 02:42PM

Hi, since this issue is now fixed in the codebase, is there any timeline on when this will be rolled out via a minor update (e.g v1.3.8)?

Would love to be able to use Exifinterface without having to use local workarounds in my apps.

ib...@google.com <ib...@google.com> #11Feb 13, 2024 02:47PM

This will be included in 1.4.0, likely released sometime in Q2 - I'm afraid we won't be doing a 1.3.8 release as the current exifinterface release branch is too old and we need to snap it to a more recent version from androidx-main.

ap...@google.com <ap...@google.com> #12Feb 26, 2024 04:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit fd3fee5a3ef4d40a3a35a869b7bfb2399e63e814
Author: Ian Baker <ibaker@google.com>
Date: Tue Feb 20 18:16:04 2024

Add comment for test added in

b/281638358

Test: ExifInterfaceTest
Bug: 281638358
Change-Id: Ied3650ee5d2bf290556c86ad546c3e28bd2f8d8a

M exifinterface/exifinterface/src/androidTest/java/androidx/exifinterface/media/ExifInterfaceTest.java

https://android-review.googlesource.com/2972131

na...@google.com <na...@google.com> #13Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

Issue 281638358

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2May 9, 2023 07:03PM

mi...@google.com <mi...@google.com> May 11, 2023 09:01AM

[Deleted User] <[Deleted User]> #3May 12, 2023 06:33PM

[Deleted User] <[Deleted User]> #4Sep 14, 2023 04:02PM

ib...@google.com <ib...@google.com> Nov 24, 2023 10:14AM

la...@gmail.com <la...@gmail.com> #5Dec 22, 2023 04:53PM

la...@gmail.com <la...@gmail.com> #6Dec 22, 2023 09:21PM

la...@gmail.com <la...@gmail.com> #7Dec 23, 2023 01:45AM

ib...@google.com <ib...@google.com> #8Jan 2, 2024 11:01AM

ap...@google.com <ap...@google.com> #9Feb 7, 2024 10:00AM

ib...@google.com <ib...@google.com> Feb 7, 2024 10:35AM

la...@gmail.com <la...@gmail.com> #10Feb 13, 2024 02:42PM

ib...@google.com <ib...@google.com> #11Feb 13, 2024 02:47PM

ap...@google.com <ap...@google.com> #12Feb 26, 2024 04:21PM

na...@google.com <na...@google.com> #13Nov 13, 2024 06:19PM

Add comment

Issue metadata