Cannot read orientation for portrait WEBP from Samsung Galaxy S22 [281638358]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 9, 2023 06:07PM

Component used: AndroidX ExifInterface Version used: 1.3.6 Devices/Android versions reproduced on: Samsung Galaxy S22 Ultra, Android 13, One UI 5.1

When reporting bugs, please always include:

A full bug report as an attachment, captured during or shortly after experiencing the issue.
Reproduction steps, being as specific as possible.
How reproducible the issue is on the affected device.
If known, how reproducible the issue is on other devices and OS versions.

Where possible, please also provide:

A sample project that reproduces the issue.
A screenrecord or screenshots showing the issue.

I attached an image that is experiencing this issue. It was captured in portrait mode and should show that in EXIF data that it was rotated 90 degrees. It appears correctly in MacOS Preview and on this online EXIF data site: https://jimpl.com/results/FWuAnboJWW1vdDpRmeUKsccb?target=exif

I added this to dependencies:

    implementation "androidx.exifinterface:exifinterface:1.3.6"

I added this to code:

                val file = context.filesDir.resolve("676x380.webp")
                URL(imageUrl).openStream().use { input ->
                    FileOutputStream(file).use { output ->
                        input.copyTo(output)
                        val exif = ExifInterface(file.path)
                        val orientation: Int =
                            exif.getAttributeInt(
                                ExifInterface.TAG_ORIENTATION,
                                ExifInterface.ORIENTATION_UNDEFINED
                            )
                        Timber.d("Orientation is $orientation")
                        Timber.d("Flipped: ${exif.isFlipped}")
                        Timber.d("Rotation degrees: ${exif.rotationDegrees}")
                    }
                }

This is the result:

D  Orientation is 0
D  Flipped: false
D  Rotation degrees: 0

676x380.webp

114 KB

View

Download

Comments

[Deleted User] <[Deleted User]> #2May 9, 2023 07:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b4a3fe1d53c8c8082cf16795da164c446f7fd912
Author: Ian Lake <ilake@google.com>
Date: Wed Jul 15 14:34:08 2020

Add a hook that fires before the Activity's super.onCreate()

Provide a standard, composable API for libraries and
developers to run code as soon as possible after a
Context is available to an Activity (i.e., before the
logic in the base Activity.onCreate() runs and before any
layout is inflated).

This updates the code in FragmentActivity and
AppCompatActivity to use that new API.

Test: new activity tests pass
Test: existing fragment and appcompat tests still pass
BUG: 161390636
Relnote: "`ComponentActivity` now implements
`ContextAware`, allowing you to add one or more
`OnContextAvailableListener` instances which will
receive a callback before the base `Activity.onCreate()`."

Change-Id: I513da73bc0862b62af4166be35ba353fc7869a09

M activity/activity/api/1.2.0-alpha07.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha07.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha07.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityLifecycleTest.kt
A activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
A activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
A activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java
A activity/activity/src/main/java/androidx/activity/contextaware/OnContextAvailableListener.java
M appcompat/appcompat/build.gradle
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java

https://android-review.googlesource.com/1364176

Message last modified on May 9, 2023 07:04PM

mi...@google.com <mi...@google.com> May 11, 2023 09:01AM

Reassigned to ib...@google.com.

[Deleted User] <[Deleted User]> #3May 12, 2023 06:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 494d98d48e3c95c4338bda7ed1bf46797de257f6
Author: Ian Lake <ilake@google.com>
Date: Mon Aug 03 13:07:36 2020

Deliver the Context when added after it is available

Previously, an OnContextAvailableListener would only
receive a callback if added prior to the Context
being made available.

Rather than allow developers fall into a pitfall
where they add a listener and never receive a
callback, synchronously deliver the currently
available Context to listeners.

Test: updated activity tests pass
BUG: 161390636
Relnote: N/A
Change-Id: I24eff02712c90e84e1998407082e0b07cf04b44a

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java

https://android-review.googlesource.com/1386006

Message last modified on May 12, 2023 06:33PM

[Deleted User] <[Deleted User]> #4Sep 14, 2023 04:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5d11382f47626211d512b9135f6b5f40b88f6647
Author: Ian Lake <ilake@google.com>
Date: Mon Aug 03 12:45:55 2020

Simplify OnContextAvailableListener interface

Rather than pass the ContextAware object,
the Context, and a Bundle for saved instance
state, pass only the Context to the
onContextAvailable() callback.

The ContextAware parameter is not needed in
general (unregistering is a corner case that
can be handled by capturing a reference to the
ContextAware).

The saved instance state Bundle is not needed
when we can ensure that the
SavedStateRegistry has had its state restored
before the listeners are called. This ensures
that all Saved State logic is centralized in
the API specifically built for saving state
rather than leaking into other APIs.

To accomplish this API change, the storage of
FragmentManager's and AppCompatDelegate's saved
state was moved to SavedStateRegistry as part of
FragmentActivity and AppCompatActivity,
respectively. Longer term, FragmentManager and
AppCompatDelegate should provide public APIs for
connecting directly to SavedStateRegistry, but
that is out of scope for this change.

Test: activity, fragment, and appcompat tests pass
BUG: 161390636
Relnote: N/A
Change-Id: I32fdd4b2c4c391c3fa97158dbd7508fa96b08d7a

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityLifecycleTest.kt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivitySavedStateTest.kt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java
M activity/activity/src/main/java/androidx/activity/contextaware/OnContextAvailableListener.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatActivity.java
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentArchLifecycleTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java

https://android-review.googlesource.com/1385861

ib...@google.com <ib...@google.com> Nov 24, 2023 10:14AM

Reassigned to an...@google.com.

la...@gmail.com <la...@gmail.com> #5Dec 22, 2023 04:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d830158f1671930bab215716e329349a42eec1dd
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 31 14:14:29 2020

Add suspending withContextAvailable to ContextAware

Expand the ContextAware interface to allow developers
to synchronously peek to see if the context is
availble.

This allows us to write a Kotlin extension
withContextAvailable() that runs a non-suspending
block once the context becomes available (either
synchronously if it is already available or by
using a OnContextAvailableListener under the hood
if not).

Test: new tests pass
BUG: 161390636
Relnote: "Added a `peekAvailableContext()` API to
`ContextAware` to allow you to synchronously determine
if a Context is available. A suspending Kotlin extension
`withContextAvailable()` allows you to run a
non-suspending block when the Context becomes available
and return a result."

Change-Id: I8290cd9de8231913036d23a233c177ed45d2d370

M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
M activity/activity-ktx/api/restricted_current.txt
A activity/activity-ktx/src/androidTest/java/androidx/activity/contextaware/ContextAwareTest.kt
A activity/activity-ktx/src/main/java/androidx/activity/contextaware/ContextAware.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/contextaware/ContextAwareHelperTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAware.java
M activity/activity/src/main/java/androidx/activity/contextaware/ContextAwareHelper.java

https://android-review.googlesource.com/1384202

Message last modified on Dec 22, 2023 05:00PM

google-exif-interface.png

2.9 MB

View

Download

laurence-exif-interface.png

2.8 MB

View

Download

la...@gmail.com <la...@gmail.com> #6Dec 22, 2023 09:21PM

Comment has been deleted.

Message last modified on Dec 23, 2023 01:43AM

la...@gmail.com <la...@gmail.com> #7Dec 23, 2023 01:45AM

Wait, this can't work as advertised.

FragmentActivity extends ComponentActivity

public FragmentActivity(@LayoutRes int contentLayoutId) {
    super(contentLayoutId);
    init();
}

private void init() {
    addOnContextAvailableListener(new OnContextAvailableListener() {
        // ...
    }
}

ComponentActivity

@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
    // ...
    mContextAwareHelper.dispatchOnContextAvailable(this);
    super.onCreate(savedInstanceState);
    //...
}

Call FragmentActivity constructor,
which calls ComponentActivity super constructor,
which dispatches context available... to noone,
and calls platform Activity.onCreate.
Bubble up to FragmentActivity constructor and register context listener,
which is invoked synchronously but only after platform Activity.onCreate has already been called.

Did I miss something? I'm confused.

ib...@google.com <ib...@google.com> #8Jan 2, 2024 11:01AM

Never mind, constructor vs onCreate. :facepalm: Sorry.

ap...@google.com <ap...@google.com> #9Feb 7, 2024 10:00AM

Marked as fixed.

Re #8 - the fact that these are different things is indeed exactly why this API exists :)

ib...@google.com <ib...@google.com> Feb 7, 2024 10:35AM

Reassigned to la...@gmail.com.

la...@gmail.com <la...@gmail.com> #10Feb 13, 2024 02:42PM

https://docs.google.com/document/d/1hyftTRyqV7ZJ5s2b_-Q9K6RJdpgedgvKP4vYoTK7i1A/edit?usp=drive_web ([Feedback] Bass Booster)

ib...@google.com <ib...@google.com> #11Feb 13, 2024 02:47PM

This will be included in 1.4.0, likely released sometime in Q2 - I'm afraid we won't be doing a 1.3.8 release as the current exifinterface release branch is too old and we need to snap it to a more recent version from androidx-main.

ap...@google.com <ap...@google.com> #12Feb 26, 2024 04:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit fd3fee5a3ef4d40a3a35a869b7bfb2399e63e814
Author: Ian Baker <ibaker@google.com>
Date: Tue Feb 20 18:16:04 2024

Add comment for test added in

b/281638358

Test: ExifInterfaceTest
Bug: 281638358
Change-Id: Ied3650ee5d2bf290556c86ad546c3e28bd2f8d8a

M exifinterface/exifinterface/src/androidTest/java/androidx/exifinterface/media/ExifInterfaceTest.java

https://android-review.googlesource.com/2972131

na...@google.com <na...@google.com> #13Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

Issue 281638358

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2May 9, 2023 07:03PM

mi...@google.com <mi...@google.com> May 11, 2023 09:01AM

[Deleted User] <[Deleted User]> #3May 12, 2023 06:33PM

[Deleted User] <[Deleted User]> #4Sep 14, 2023 04:02PM

ib...@google.com <ib...@google.com> Nov 24, 2023 10:14AM

la...@gmail.com <la...@gmail.com> #5Dec 22, 2023 04:53PM

la...@gmail.com <la...@gmail.com> #6Dec 22, 2023 09:21PM

la...@gmail.com <la...@gmail.com> #7Dec 23, 2023 01:45AM

ib...@google.com <ib...@google.com> #8Jan 2, 2024 11:01AM

ap...@google.com <ap...@google.com> #9Feb 7, 2024 10:00AM

ib...@google.com <ib...@google.com> Feb 7, 2024 10:35AM

la...@gmail.com <la...@gmail.com> #10Feb 13, 2024 02:42PM

ib...@google.com <ib...@google.com> #11Feb 13, 2024 02:47PM

ap...@google.com <ap...@google.com> #12Feb 26, 2024 04:21PM

na...@google.com <na...@google.com> #13Nov 13, 2024 06:19PM

Add comment

Issue metadata