Duplicate

of 265347515

Bug

Status Update

No update yet.

Description

ha...@reddit.com

created issue #1

May 19, 2023 09:22AM

Jetpack Compose version: 2023.03.00 (BOM)
Jetpack Compose component used: ComposeView
Android Studio Build: Build #AI-222.4459.24.2221.9862592, built on March 31, 2023
Kotlin version: 1.8.10
RecyclerView version: 1.3.0

Steps to Reproduce or Code Sample to Reproduce:

See MainActivity in attached sample project, or:

Note: RV refers to RecyclerView

Add RecyclerView
Elements of RecyclerView are empty FrameLayouts
In onBindViewHolder of the RV adapter, create ComposeView and add it as a child to the FrameLayout. Call setContent on the ComposeView with arbitrary layout (e.g. colored Box)
On the RV adapter, call notifyItemChanged(0, Any())

Behavior:

What I would expect to happen: No crash happens

What actually happens:

During the onBindViewHolder call, the parent field of the RecyclerView item view will be null, but its mAttachInfo will not be null
Because of that, when the ComposeView is added to the item view, its isAttachedToWindow will be true, and it will try to create a composition.
In order to do that, Compose tries to find a ViewTreeLifecycleOwner using View.findViewTreeLifecycleOwner() which tries walking up the view hierarchy to obtain the owner from the root view.
Because the RV item has no parent, View.findViewTreeLifecycleOwner() returns null, and View.createLifecycleAwareWindowRecomposer() throws and crashes the app.

Stack trace (if applicable):

FATAL EXCEPTION: main
Process: com.example.recyclerviewcomposetest, PID: 13374
java.lang.IllegalStateException: ViewTreeLifecycleOwner not found from android.widget.FrameLayout{95d02ab VFE...C.. ...P..ID 0,0-1080,176}
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer(WindowRecomposer.android.kt:350)
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer$default(WindowRecomposer.android.kt:325)
    at androidx.compose.ui.platform.WindowRecomposerFactory$Companion$LifecycleAware$1.createRecomposer(WindowRecomposer.android.kt:168)
    at androidx.compose.ui.platform.WindowRecomposerPolicy.createAndInstallWindowRecomposer$ui_release(WindowRecomposer.android.kt:224)
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.getWindowRecomposer(WindowRecomposer.android.kt:300)
    at androidx.compose.ui.platform.AbstractComposeView.resolveParentCompositionContext(ComposeView.android.kt:244)
    at androidx.compose.ui.platform.AbstractComposeView.ensureCompositionCreated(ComposeView.android.kt:251)
    at androidx.compose.ui.platform.AbstractComposeView.createComposition(ComposeView.android.kt:196)
    at androidx.compose.ui.platform.ComposeView.setContent(ComposeView.android.kt:444)
    at com.example.recyclerviewcomposetest.MyAdapter.onBindViewHolder(MainActivity.kt:83)
    at com.example.recyclerviewcomposetest.MyAdapter.onBindViewHolder(MainActivity.kt:51)
    at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7678)
    at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7761)
    at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6582)
    at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6848)
    at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6688)
    at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6684)
    at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
    at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
    at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
    at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
    at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4604)
    at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4307)
    at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4873)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at com.android.internal.policy.DecorView.onLayout(DecorView.java:799)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4097)
    at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3438)
    at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2350)
    at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9194)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
    at android.view.Choreographer.doCallbacks(Choreographer.java:899)
    at android.view.Choreographer.doFrame(Choreographer.java:832)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
    at android.os.Handler.handleCallback(Handler.java:942)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:201)
    at android.os.Looper.loop(Looper.java:288)
    at android.app.ActivityThread.main(ActivityThread.java:7884)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

ReproSampleProject.zip

111 KB

Download

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

Assigned to ry...@google.com.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

Status: Duplicate of

265347515

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

IssueTracker

Crash when dynamically adding ComposeView to RecyclerView item

Status Update

Description

Steps to Reproduce or Code Sample to Reproduce:

Behavior:

What I would expect to happen: No crash happens

What actually happens:

Stack trace (if applicable):

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

Issue 283288295

Description

Steps to Reproduce or Code Sample to Reproduce:

Behavior:

What I would expect to happen: No crash happens

What actually happens:

Stack trace (if applicable):

Issue summary

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

Add comment

Issue metadata