Duplicate

of 265347515

Bug

Status Update

No update yet.

Description

ha...@reddit.com

created issue #1

May 19, 2023 09:22AM

Jetpack Compose version: 2023.03.00 (BOM)
Jetpack Compose component used: ComposeView
Android Studio Build: Build #AI-222.4459.24.2221.9862592, built on March 31, 2023
Kotlin version: 1.8.10
RecyclerView version: 1.3.0

Steps to Reproduce or Code Sample to Reproduce:

See MainActivity in attached sample project, or:

Note: RV refers to RecyclerView

Add RecyclerView
Elements of RecyclerView are empty FrameLayouts
In onBindViewHolder of the RV adapter, create ComposeView and add it as a child to the FrameLayout. Call setContent on the ComposeView with arbitrary layout (e.g. colored Box)
On the RV adapter, call notifyItemChanged(0, Any())

Behavior:

What I would expect to happen: No crash happens

What actually happens:

During the onBindViewHolder call, the parent field of the RecyclerView item view will be null, but its mAttachInfo will not be null
Because of that, when the ComposeView is added to the item view, its isAttachedToWindow will be true, and it will try to create a composition.
In order to do that, Compose tries to find a ViewTreeLifecycleOwner using View.findViewTreeLifecycleOwner() which tries walking up the view hierarchy to obtain the owner from the root view.
Because the RV item has no parent, View.findViewTreeLifecycleOwner() returns null, and View.createLifecycleAwareWindowRecomposer() throws and crashes the app.

Stack trace (if applicable):

FATAL EXCEPTION: main
Process: com.example.recyclerviewcomposetest, PID: 13374
java.lang.IllegalStateException: ViewTreeLifecycleOwner not found from android.widget.FrameLayout{95d02ab VFE...C.. ...P..ID 0,0-1080,176}
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer(WindowRecomposer.android.kt:350)
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer$default(WindowRecomposer.android.kt:325)
    at androidx.compose.ui.platform.WindowRecomposerFactory$Companion$LifecycleAware$1.createRecomposer(WindowRecomposer.android.kt:168)
    at androidx.compose.ui.platform.WindowRecomposerPolicy.createAndInstallWindowRecomposer$ui_release(WindowRecomposer.android.kt:224)
    at androidx.compose.ui.platform.WindowRecomposer_androidKt.getWindowRecomposer(WindowRecomposer.android.kt:300)
    at androidx.compose.ui.platform.AbstractComposeView.resolveParentCompositionContext(ComposeView.android.kt:244)
    at androidx.compose.ui.platform.AbstractComposeView.ensureCompositionCreated(ComposeView.android.kt:251)
    at androidx.compose.ui.platform.AbstractComposeView.createComposition(ComposeView.android.kt:196)
    at androidx.compose.ui.platform.ComposeView.setContent(ComposeView.android.kt:444)
    at com.example.recyclerviewcomposetest.MyAdapter.onBindViewHolder(MainActivity.kt:83)
    at com.example.recyclerviewcomposetest.MyAdapter.onBindViewHolder(MainActivity.kt:51)
    at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7678)
    at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7761)
    at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6582)
    at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6848)
    at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6688)
    at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6684)
    at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
    at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
    at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
    at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
    at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4604)
    at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4307)
    at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4873)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
    at com.android.internal.policy.DecorView.onLayout(DecorView.java:799)
    at android.view.View.layout(View.java:23716)
    at android.view.ViewGroup.layout(ViewGroup.java:6413)
    at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4097)
    at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3438)
    at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2350)
    at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9194)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
    at android.view.Choreographer.doCallbacks(Choreographer.java:899)
    at android.view.Choreographer.doFrame(Choreographer.java:832)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
    at android.os.Handler.handleCallback(Handler.java:942)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:201)
    at android.os.Looper.loop(Looper.java:288)
    at android.app.ActivityThread.main(ActivityThread.java:7884)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

ReproSampleProject.zip

111 KB

Download

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

Assigned to ry...@google.com.

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

Status: Duplicate of

265347515

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

Add autovalue support also means you can easily achieve parcelable by

https://github.com/rharter/auto-value-parcel. Please consider support this.

IssueTracker

Crash when dynamically adding ComposeView to RecyclerView item

Status Update

Description

Steps to Reproduce or Code Sample to Reproduce:

Behavior:

What I would expect to happen: No crash happens

What actually happens:

Stack trace (if applicable):

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

Issue 283288295

Description

Steps to Reproduce or Code Sample to Reproduce:

Behavior:

What I would expect to happen: No crash happens

What actually happens:

Stack trace (if applicable):

Issue summary

Comments

ha...@reddit.com <ha...@reddit.com> #2May 19, 2023 09:36AM

ma...@google.com <ma...@google.com> #3May 19, 2023 01:11PM

ry...@google.com <ry...@google.com> #4May 23, 2023 10:18PM

ry...@google.com <ry...@google.com> #5May 24, 2023 10:10PM

ha...@reddit.com <ha...@reddit.com> #6May 25, 2023 08:02AM

Add comment

Issue metadata