App crashes Navigation: open an app by the deeplink when back pressed. [287133013]

Duplicate

of 301887045

Bug

Status Update

No update yet.

Description

yo...@gmail.com

created issue #1

Jun 14, 2023 07:00AM

Component used: Navigation
Version used: navigation-fragment-ktx, navigation-ui-ktx 2.6.0
Devices/Android versions reproduced on: All

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue in the following github link:

https://github.com/yotheone0909/NavigationDeeplinkDynamicBottomNav
When I open an app by the deep-link and back-pressing, it crashes. Also, bottom navigation tab 2 has dynamic fragment logic. It will change fragments when the API has a data response. (A sample project doesn't use the API.)

FATAL EXCEPTION: main
Process: com.example.navigationdeeplink, PID: 21948
java.lang.IllegalArgumentException: The fragment SecondFragment{389b31b} (e54e1f09-0f45-4e6c-a668-35e52c4c6ffc id=0x7f0800cc tag=cf5dd8f1-9576-4c91-975d-73e99d7e34b2) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:143)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7884)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Issue does not occur when downgrade version 2.6.0 to 2.5.3 or normal open an app

Steps to reproduce
1. run script deeplink (file name test_deeplink.sh in a project)
2. press back system
3. App crashes with the above error

Comments

il...@google.com <il...@google.com> Jun 14, 2023 04:45PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> #2Jun 15, 2023 12:58AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019

Add NavDirections overload for createOnClickListener in Navigation

Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.

Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11

M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java

https://android-review.googlesource.com/930453

https://goto.google.com/android-sha1/44991c9a6f7d832decb7a19b9d795f8644bc8503

yo...@gmail.com <yo...@gmail.com> #3Jun 19, 2023 01:37AM

This has been added internally and will be available in Navigation 2.1.0-alpha01

jb...@google.com <jb...@google.com> #4Jun 20, 2023 03:49PM

Have SecondFragment as part of your graph and then inside of SecondFragment call the childFragmentManager and replace with the fragment you actually want to show, whether that is SecondTypeOne or SecondTypeTwo.
Create different graphs and follow along with the docs on using different graphs dynamically and inflate and set the one needed based on logic in your Activity.

yo...@gmail.com <yo...@gmail.com> #5Jun 27, 2023 05:57AM

Thank you very much. Now the issue does not occur. When I added this code below in SecondFragment

shardViewModel.onGetTypeSecond.observe(viewLifecycleOwner) { isType1 ->
if (isType1) {
val graph = findNavController().graph
val carInstallmentNavGraph =
graph.findNode(R.id.nav_second) as NavGraph
carInstallmentNavGraph.setStartDestination(R.id.secondTypeOneFragment)
findNavController().navigate(SecondFragmentDirections.actionSecondFragmentToSecondTypeOneFragment())
} else {
val graph = findNavController().graph
val carInstallmentNavGraph =
graph.findNode(R.id.nav_second) as NavGraph
carInstallmentNavGraph.setStartDestination(R.id.secondTypeTwoFragment)
findNavController().navigate(SecondFragmentDirections.actionSecondFragmentToSecondTypeTwoFragment())
}
}

and removed app:popUpTo="@id/secondFragment" and app:popUpToInclusive="true"

<fragment
android:id="@+id/secondFragment"
android:name="com.example.navigationdeeplink.SecondFragment"
android:label="fragment_second"
tools:layout="@layout/fragment_second" >
<action
android:id="@+id/action_secondFragment_to_secondTypeOneFragment"
app:destination="@id/secondTypeOneFragment" />
<action
android:id="@+id/action_secondFragment_to_secondTypeTwoFragment"
app:destination="@id/secondTypeTwoFragment"
app:popUpTo="@id/secondFragment" />
</fragment>

ja...@gmail.com <ja...@gmail.com> #6Sep 22, 2023 02:42PM

Is there a planned fix for this issue? We've been stuck on Navigation 2.5.3 for some time due to issues in 2.6.x and now this issue, and the suggested workaround of restructuring our navigation graph is a pretty big lift. If that's the only recommended path it would be helpful to know so we can try to plan for that work, otherwise we'd want to just wait for the fix that doesn't require restructuring.

jb...@google.com <jb...@google.com> #7Sep 27, 2023 09:33PM

Status: Duplicate of

301887045

This was fixed by https://issuetracker.google.com/301887045 and will be available in the Navigation 2.7.4 release. We are also adding a regression test for this particular case.

ap...@google.com <ap...@google.com> #8Sep 27, 2023 10:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit b292676aa37122f0ca0215023dcdbe27168b2469
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 27 21:25:35 2023

Add a test for navigate with popUpTo nested graph

Adding a test to ensure that if the start destination of a nested graph
is popped off the back stack when a fragment is created, Navigation does
not crash and gets to the correct position.

Bug: 287133013
Test: adding a test
Change-Id: Ie1e03aeeb00b730b7688311741847b2312bdbaa0

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt

https://android-review.googlesource.com/2765553

na...@google.com <na...@google.com> #9Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.8.0-alpha01