NavBackStackEntry lifecycle not updated correctly when there are multiple FloatingWindow destinations on the back stack [287505132]

Fixed

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jun 16, 2023 07:18PM

Component used: Navigation
Version used: 2.6.0
Devices/Android versions reproduced on: Emulator Android 13

Very simple scenario for demo purposes:
1. MainFragment navigates to Dialog1Fragment
2. Dialog1Fragment navigates to Dialog2Fragment
3. Dialog2Fragment navigates back

This will result in the lifecycle of Dialog1Fragment's NavBackStackEntry to go back into `ON_START` but it will never go back to `ON_RESUME` even though it is now the top destination on the stack.

I've attached a small sample project with these 3 fragments

test.zip

113 KB

Download

Comments

ga...@gmail.com <ga...@gmail.com> #2Jun 16, 2023 07:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 82941c128d8ef57e36a739fcfacdf006e94d1a4a
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Thu Oct 15 17:31:58 2020

[GH] Don't cache fragment classes across different class loaders

## Proposed Changes

- Don't cache fragment classes across different class loaders inside `FragmentFactory`.

## Testing

Test: Added tests to verify the change

## Issues Fixed

Fixes: 113886460

This is an imported pull request from

https://github.com/androidx/androidx/pull/87.

Resolves #87
Github-Pr-Head-Sha: e5f5916840904cab91884e3f525fde4a71d5a7dc
GitOrigin-RevId: babb5e1aedec7d815aa38a50ebca89d6c3e93f00
Change-Id: I07d5541a45ccadcf7159854818000455e245d118

M fragment/fragment/src/main/java/androidx/fragment/app/FragmentFactory.java
A fragment/fragment/src/test/java/androidx/fragment/app/FragmentFactoryTest.kt

https://android-review.googlesource.com/1462523

jb...@google.com <jb...@google.com> Jun 16, 2023 08:08PM

Assigned to cl...@google.com.

ga...@freeletics.com <ga...@freeletics.com> #3Aug 1, 2023 06:19AM

The bug also affects compose and is actually a lot worse there since the LocalLifecycleOwner is the one of the NavBackStackEntry, so anything that is tied to the lifecycle will not work at all.

cl...@google.com <cl...@google.com> #4Aug 30, 2023 05:38PM

Accepted by cl...@google.com.

Re: comment#1 yes that was a separate bug where visible entries were not moving to STARTED. It has been fixed.

Re: comment#3 this bug's equivalent in Compose was reported and fixed.

Message last modified on Aug 30, 2023 06:04PM

ap...@google.com <ap...@google.com> #5Aug 31, 2023 07:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 34427f031ebd1b5e3336137c89f532f004aa71f9
Author: Clara Fok <clarafok@google.com>
Date: Wed Aug 30 14:17:10 2023

Fix DialogFragment not marked transition complete

When navigating to new DialogFragment, the current open DialogFragment (outoing entry) is marked as transitioning. Likewise, when popping a DialogFragment, the incoming entry is marked as transitioning. However in both cases, the entry is not marked complete after navigation/pop. In the second case, it prevents the incoming entry from moving to RESUMED state.

Now we ensure to remove the entries from its transient transitioning state so it can move to proper lifecycle state.

Test: ./gradlew navigation:navigation-fragment:cC
Bug: 287505132
Change-Id: I3b866a44291e7bd7af742562ae0619cd83929a1a

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/DialogFragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/DialogFragmentNavigator.kt

https://android-review.googlesource.com/2734817

cl...@google.com <cl...@google.com> #6Aug 31, 2023 07:52PM

Marked as fixed.

Fixed internally and will be available in navigation 2.7.3

na...@google.com <na...@google.com> #7Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3

na...@google.com <na...@google.com> #8Jan 24, 2024 07:53PM