NavBackStackEntry lifecycle not updated correctly when there are multiple FloatingWindow destinations on the back stack [287505132]

Fixed

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jun 16, 2023 07:18PM

Component used: Navigation
Version used: 2.6.0
Devices/Android versions reproduced on: Emulator Android 13

Very simple scenario for demo purposes:
1. MainFragment navigates to Dialog1Fragment
2. Dialog1Fragment navigates to Dialog2Fragment
3. Dialog2Fragment navigates back

This will result in the lifecycle of Dialog1Fragment's NavBackStackEntry to go back into `ON_START` but it will never go back to `ON_RESUME` even though it is now the top destination on the stack.

I've attached a small sample project with these 3 fragments

test.zip

113 KB

Download

Comments

ga...@gmail.com <ga...@gmail.com> #2Jun 16, 2023 07:45PM

since these are in public API (:/) we need to do this in 1.2

jb...@google.com <jb...@google.com> Jun 16, 2023 08:08PM

Assigned to cl...@google.com.

ga...@freeletics.com <ga...@freeletics.com> #3Aug 1, 2023 06:19AM

since it is already marked as deprecated, we can probably do it by now.

cl...@google.com <cl...@google.com> #4Aug 30, 2023 05:38PM

Accepted by cl...@google.com.

Opening diff shortly

Message last modified on Aug 30, 2023 06:04PM

ap...@google.com <ap...@google.com> #5Aug 31, 2023 07:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

cl...@google.com <cl...@google.com> #6Aug 31, 2023 07:52PM

Marked as fixed.

Fixed internally and will be available in navigation 2.7.3

na...@google.com <na...@google.com> #7Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3

na...@google.com <na...@google.com> #8Jan 24, 2024 07:53PM