Status Update
No update yet.
Comments
jb...@google.com
ap...@google.com
Are there many use cases for this? The current logic works fine with dark mode of platform, appcompat, and Compose.
ap...@google.com
When I was trying out integrating this with Now in Android, I ran into this issue since Now in Android currently doesn't inherit from AppCompatActivity and doesn't call AppCompatDelegate.setDefaultNightMode, so maybe the solution is instead to inherit from AppCompatActivity instead of just ComponentActivity to update the underlying configuration.
jb...@google.com
I just tested it with ComponentActivity. It's working fine for me. The scrim for 3-button nav and the icons are properly changed on light/dark mode switch. The extension function detect light/dark mode from resources.configuration.uiMode which is commonly used by the platform, AppCompat, and Compose, so I don't know why it doesn't work. Can I take a look at what you tried in Now in Android.
Description
Component used: Activity
Version used: 1.7.2
As explained
OnBackPressedCallbackfor non-UI cases (for example, just for logging back). If you add a callback, you have to handle back completely in your callback.That means that calling
remove()and triggering back viarequireActivity.onBackPressed()oronBackPressedDispatcher.onBackPressed()is always an anti-pattern and something that you should not do.It would be helpful if there was a Lint error that specifically catch this case and warn developers ahead of time that this is the wrong thing to do and offer alternatives or at least link to the guide for more information.