Cannot extend ComponentDialog after upgrading to androidx.fragment 1.6.0 (Kotlin only) [287509323]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Jun 16, 2023 06:58AM

Component used: Fragment, ComponentDialog

Version used: 1.6.0

Devices/Android versions reproduced on:

Android Studio 2022.2.1 Patch 2
compileSdk 33
minSdk 28
targetSdk 33
Kotlin compiler 1.6.20 and 1.6.10

After upgrading androidx.fragment to 1.6.0 from 1.5.5, I am unable to compile when attempting to subclass ComponentDialog. An error is generated that says:

Class 'MyComponentDialog’ is not abstract and does not implement abstract base class member public abstract val lifecycle: Lifecycle defined in androidx.activity.ComponentDialog

If I convert MyComponentDialog to Java, it works as expected.

I copied the source code for ComponentDialog and commented out the references to ViewTreeLifecycleOwner (since I don’t have access to that) and found the compiler generated the same error for ComponentDialog itself.

In ComponentDialog, if I replace:

final override fun getLifecycle(): Lifecycle = lifecycleRegistry

with

final override val lifecycle: Lifecycle = lifecycleRegistry

the compiler no longer complains and the class can be extended.

The problem can be easily demonstrated with the following Kotlin code:

package com.problem

import android.content.context
import androidx.activity.ComponentDialog

class MyComponentDialog @JvmOverloads constructor(
    context: Context,
    theme: Int = 0
) : ComponentDialog(context, theme) {
    // Nothing special needed to show the problem
}

Other than converting MyComponentDialog to Java, I could not find a solution.

Comments

jb...@google.com <jb...@google.com> #2Jun 16, 2023 03:35PM

What about Enums? Enum is a type-safe way to pass navigation arguments.
Will Enums be covered in this issue as part of Serializable or will have own handled separately?
Because for enum you can provide a reasonable default value but for Parcelable or Serializable only @null

tp...@gmail.com <tp...@gmail.com> #3Jun 16, 2023 07:49PM

Please add support for Serializable objects so Enums can be used.

jb...@google.com <jb...@google.com> #4Jun 20, 2023 02:13PM

Support of Serializable objects is not enough for enums, you definitely need also the support of default values.

il...@google.com <il...@google.com> #5Jun 23, 2023 09:30PM

Marked as fixed, reassigned to il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

Issue 287509323

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jun 16, 2023 03:35PM

tp...@gmail.com <tp...@gmail.com> #3Jun 16, 2023 07:49PM

jb...@google.com <jb...@google.com> #4Jun 20, 2023 02:13PM

il...@google.com <il...@google.com> #5Jun 23, 2023 09:30PM

Add comment

Issue metadata