Fixed
Status Update
Comments
tp...@gmail.com <tp...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 428f0ec685ff80035c0511c0cdb12b9770b6159c
Author: Maxim Savoskin <maximsavoskin@gmail.com>
Date: Mon Mar 29 13:20:52 2021
[GH] [Lifecycle] [Lint] fixes b/183696616 : KtCallExpression is not always the first in the list
## Proposed Changes
KtCallExpression is not always the first in the list. In this case, it is KtModifierList.
## Testing
Test: ./gradlew test lint buildOnServer
## Issues Fixed
Fixes:https://issuetracker.google.com/issues/183696616
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/147 .
Resolves #147
Github-Pr-Head-Sha: 3c2693e2f4cceb367c9c169749d1391a9da2740f
GitOrigin-RevId: a6440720029b1c0c702207f1393d3b01180691b8
Change-Id: I9b4383329b9ece85e3bffa4a9bf8e8a3f0c3d84a
M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
https://android-review.googlesource.com/1656820
Branch: androidx-main
commit 428f0ec685ff80035c0511c0cdb12b9770b6159c
Author: Maxim Savoskin <maximsavoskin@gmail.com>
Date: Mon Mar 29 13:20:52 2021
[GH] [Lifecycle] [Lint] fixes
## Proposed Changes
KtCallExpression is not always the first in the list. In this case, it is KtModifierList.
## Testing
Test: ./gradlew test lint buildOnServer
## Issues Fixed
Fixes:
This is an imported pull request from
Resolves #147
Github-Pr-Head-Sha: 3c2693e2f4cceb367c9c169749d1391a9da2740f
GitOrigin-RevId: a6440720029b1c0c702207f1393d3b01180691b8
Change-Id: I9b4383329b9ece85e3bffa4a9bf8e8a3f0c3d84a
M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt
jb...@google.com <jb...@google.com> #4
Will you guys be releasing a hot fix 2.3.2 for this?
il...@google.com <il...@google.com> #5
Any updates about when this is going live?
Description
Component used: Fragment, ComponentDialog
Version used: 1.6.0
Devices/Android versions reproduced on:
After upgrading androidx.fragment to 1.6.0 from 1.5.5, I am unable to compile when attempting to subclass ComponentDialog. An error is generated that says:
If I convert
MyComponentDialog
to Java, it works as expected.I copied the source code for ComponentDialog and commented out the references to ViewTreeLifecycleOwner (since I don’t have access to that) and found the compiler generated the same error for ComponentDialog itself.
In ComponentDialog, if I replace:
with
the compiler no longer complains and the class can be extended.
The problem can be easily demonstrated with the following Kotlin code:
Other than converting
MyComponentDialog
to Java, I could not find a solution.