Cannot extend ComponentDialog after upgrading to androidx.fragment 1.6.0 (Kotlin only) [287509323]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Jun 16, 2023 06:58AM

Component used: Fragment, ComponentDialog

Version used: 1.6.0

Devices/Android versions reproduced on:

Android Studio 2022.2.1 Patch 2
compileSdk 33
minSdk 28
targetSdk 33
Kotlin compiler 1.6.20 and 1.6.10

After upgrading androidx.fragment to 1.6.0 from 1.5.5, I am unable to compile when attempting to subclass ComponentDialog. An error is generated that says:

Class 'MyComponentDialog’ is not abstract and does not implement abstract base class member public abstract val lifecycle: Lifecycle defined in androidx.activity.ComponentDialog

If I convert MyComponentDialog to Java, it works as expected.

I copied the source code for ComponentDialog and commented out the references to ViewTreeLifecycleOwner (since I don’t have access to that) and found the compiler generated the same error for ComponentDialog itself.

In ComponentDialog, if I replace:

final override fun getLifecycle(): Lifecycle = lifecycleRegistry

with

final override val lifecycle: Lifecycle = lifecycleRegistry

the compiler no longer complains and the class can be extended.

The problem can be easily demonstrated with the following Kotlin code:

package com.problem

import android.content.context
import androidx.activity.ComponentDialog

class MyComponentDialog @JvmOverloads constructor(
    context: Context,
    theme: Int = 0
) : ComponentDialog(context, theme) {
    // Nothing special needed to show the problem
}

Other than converting MyComponentDialog to Java, I could not find a solution.

Comments

jb...@google.com <jb...@google.com> #2Jun 16, 2023 03:35PM

Seems to be a DNS problem with systems that have 'obtain DNS server address automatically'. Changed my system to a manual setting and the browser etc now work. SDK 2.2 didn't seem to mind the auto setting though.

tp...@gmail.com <tp...@gmail.com> #3Jun 16, 2023 07:49PM

Could you please describe how/where you changed your system to a manual setting?

jb...@google.com <jb...@google.com> #4Jun 20, 2023 02:13PM

Based on its date, this issue was originally reported before Android 2.3. Because of the many changes that existed in Android 4.x compared to previous versions, it's very likely that this issue doesn't exist in recent versions of Android like 4.2.2 or newer. Because of the high likelihood that this issue is obsolete, it is getting closed automatically by a script, without a human looking at it in detail. If the issue still exists on a Nexus 4 or Nexus 7 running Android 4.2.2 and is not related to Google applications, please open a new report accordingly.

il...@google.com <il...@google.com> #5Jun 23, 2023 09:30PM

Marked as fixed, reassigned to il...@google.com.

java.lang.IllegalArgumentException: Unable to locate adb
at com.android.tools.idea.run.editor.DeployTargetPickerDialog.<init>(DeployTargetPickerDialog.java:144)
at com.android.tools.idea.run.editor.ShowChooserTargetProvider.showPrompt(ShowChooserTargetProvider.java:113)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getDeployTarget(AndroidRunConfigurationBase.java:600)
at com.android.tools.idea.run.AndroidRunConfigurationBase.doGetState(AndroidRunConfigurationBase.java:281)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getState(AndroidRunConfigurationBase.java:241)
at com.intellij.execution.runners.ExecutionEnvironment.getState(ExecutionEnvironment.java:158)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:55)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:50)
at com.intellij.execution.ProgramRunnerUtil.executeConfigurationAsync(ProgramRunnerUtil.java:92)
at com.intellij.execution.ProgramRunnerUtil.executeConfiguration(ProgramRunnerUtil.java:41)
at com.intellij.execution.impl.ExecutionManagerImpl.restart(ExecutionManagerImpl.java:93)
at com.intellij.execution.impl.ExecutionManagerImpl.access$300(ExecutionManagerImpl.java:44)
at com.intellij.execution.impl.ExecutionManagerImpl$3.run(ExecutionManagerImpl.java:442)
at com.intellij.util.concurrency.QueueProcessor.runSafely(QueueProcessor.java:232)
at com.intellij.util.Alarm$Request.runSafely(Alarm.java:356)
at com.intellij.util.Alarm$Request.run(Alarm.java:343)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:228)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:435)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:419)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:403)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:755)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:391)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

Issue 287509323

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jun 16, 2023 03:35PM

tp...@gmail.com <tp...@gmail.com> #3Jun 16, 2023 07:49PM

jb...@google.com <jb...@google.com> #4Jun 20, 2023 02:13PM

il...@google.com <il...@google.com> #5Jun 23, 2023 09:30PM

Add comment

Issue metadata