2.6.0-alpha05 NavController visibleEntries flow contains many wrong entries [288520638]

Fixed

Bug

Status Update

No update yet.

Description

th...@outlook.com

created issue #1

Jun 23, 2023 12:30PM

Component used: Navigation
Version used: 2.6.0-alpha05 and up (including 2.6.0 stable)
Devices/Android versions reproduced on: Any

In the sample project I try to determine if the home fragment is visible using NavController.visibleEntries. In library version alpha04 it always contains the correct entries, but in alpha05 the list is a hot mess because it keeps growing when navigating and even the host fragment and fragments that are not on the backstack are added to the list. This is not possible in the sample project.

The sample project logs the information for demonstration.

VisibleEntriesBugReport.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> Jun 23, 2023 10:07PM

Assigned to cl...@google.com.

th...@outlook.com <th...@outlook.com> #2Aug 30, 2023 09:57AM

Duplicate of internal issue b/155379937. Fixed in 1.2.0-rc02:

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 45a1bc4a15b5b10d0635d79fb55df2aced5a2a4a
Author: Alan Viverette <alanv@google.com>
Date:   Thu May 14 18:06:25 2020

    Only apply DayNight changes to Activity-hosted delegates
   
    Dialogs can't receive configuration change callbacks, so there's no point
    in updating their configurations. They'll have to be destroyed and re-
    created by their host activities. Also, dialogs were eating the changes.
   
    Fixes: 155379937
    Test: NightModeForegroundDialogTestCase and appcompat test suite
    Change-Id: Ifa18d9d42268ec8821223942dc6c817ecabbed7f

A       appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeDialogFragment.java
A       appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeForegroundDialogTestCase.kt
M       appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M       appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java

il...@google.com <il...@google.com> #3Aug 30, 2023 04:52PM

I think, sActiveDelegates meant "live" delegates. Anyway, now there's a mess :(

private static final ArraySet<WeakReference<AppCompatDelegate>> sActivityDelegates;
private static final Object sActivityDelegatesLock;

static void addActiveDelegate(@NonNull AppCompatDelegate delegate);
static void removeActivityDelegate(@NonNull AppCompatDelegate delegate);
private static void removeDelegateFromActives(@NonNull AppCompatDelegate toRemove);
private static void applyDayNightToActiveDelegates();

Source: https://android-review.googlesource.com/c/platform/frameworks/support/+/1348308/

ap...@google.com <ap...@google.com> #4Sep 7, 2023 05:19PM

Re: comment#3, I don't follow. Are you saying there is still an issue in 1.2.0.rc02 or just commenting on the overall code structure?

cl...@google.com <cl...@google.com> #5Sep 7, 2023 05:25PM

Marked as fixed.

Rc02 is work for me, thanks for your work!

na...@google.com <na...@google.com> #6Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3
androidx.navigation:navigation-runtime:2.7.3

th...@outlook.com <th...@outlook.com> #7Sep 21, 2023 08:48AM

The issue no longer persists in version 2.7.3. Thank you all for the update.

na...@google.com <na...@google.com> #8Jan 24, 2024 07:53PM