DataStore CorruptionException not handled in reads after initialization succeeds [289582516]

Fixed

Bug

Status Update

No update yet.

Description

zh...@google.com

created issue #1

Jul 1, 2023 12:16AM

After a few code refactors and bug fixes, DataStoreImpl no longer handles CorruptionException in reads after initialization is successful.

Specifically, readDataOrHandleCorruption is only used in InitDataStore, while readState calls readDataAndUpdateCache which calls attemptRead which simply caches a ReadException if any exception is thrown from the read; updateCollector also calls readDataAndUpdateCache thus doesn't catch CorruptionException.

Create the bug to track the fix.

Comments

zh...@google.com <zh...@google.com> Jul 1, 2023 12:16AM

Reassigned to zh...@google.com.

zh...@google.com <zh...@google.com> Feb 20, 2024 10:06PM

Accepted by zh...@google.com.

zh...@google.com <zh...@google.com> #2Feb 21, 2024 09:01PM

Thank you for the report. We will try to fix this soon. In the meantime, could you please start the emulator from the console (see the commands below), open the camera app to crash it and attach the output, it might help to figure out what the problem is:

cd /Users/YOUR_USERNAME/Library/Android/sdk/emulator
./emulator -list-avds
./emulator -verbose -avd YOUR_AVD_FROM_PREVIOUS_STEP

if there is a crash report to send, please send it and attach the report id.

yb...@google.com <yb...@google.com> #3Feb 21, 2024 09:16PM

We got a crash report (thanks JP): 872e3b20bc34905b. It says EXC_BAD_INSTRUCTION / 0x00000001 and the console also says "Illegal hardware instruction". I suspect the new MacOS brought a new hypervizor which causes this behavior. Haitao, could you please take a look?

zh...@google.com <zh...@google.com> #4Feb 21, 2024 11:10PM

We have quite some crashes like this:

product_name="AndroidEmulator" AND crash.Reason="EXC_BAD_INSTRUCTION / 0x00000001" AND cpu.Architecture="arm64"

ap...@google.com <ap...@google.com> #5Feb 24, 2024 12:44AM

The most of crashes happen here:

vVertical_Scale_ARGB_8888_Accelerate
vImageVerticalShear_ARGB8888
vImageVerticalShear_ARGB8888
vImageScale_ARGB8888

vRotateClockwise270Degree_ARGB8888_Accelerate2
vRotate_90_ARGB_8888_270Degree_Accelerate2

ap...@google.com <ap...@google.com> #6Feb 29, 2024 02:12AM

Marked as fixed.

I suspect EXC_BAD_INSTRUCTION happens in vImageRotate90_ARGB8888 and vImageScale_ARGB8888 which are used by webcam on MacOS.

na...@google.com <na...@google.com> #7Mar 6, 2024 07:49PM

With complete honesty, I have to say that I’m extremely disappointed by the handling of this issue by google and by the fact that it came out in the first place. I need to use android studio for work purposes and I am forced to switch to a different machine. Mac OS Sonoma has been in beta testing for months and google has had plenty of time to ensure the application would be properly running. I expect this issue to have the maximum priority and to be solved very soon.