DataStore CorruptionException not handled in reads after initialization succeeds [289582516]

Fixed

Bug

Status Update

No update yet.

Description

zh...@google.com

created issue #1

Jul 1, 2023 12:16AM

After a few code refactors and bug fixes, DataStoreImpl no longer handles CorruptionException in reads after initialization is successful.

Specifically, readDataOrHandleCorruption is only used in InitDataStore, while readState calls readDataAndUpdateCache which calls attemptRead which simply caches a ReadException if any exception is thrown from the read; updateCollector also calls readDataAndUpdateCache thus doesn't catch CorruptionException.

Create the bug to track the fix.

Comments

zh...@google.com <zh...@google.com> Jul 1, 2023 12:16AM

Reassigned to zh...@google.com.

zh...@google.com <zh...@google.com> Feb 20, 2024 10:06PM

Accepted by zh...@google.com.

zh...@google.com <zh...@google.com> #2Feb 21, 2024 09:01PM

Might be related to

https://issuetracker.google.com/issues/118020865. BTW, I'm using 1.1.0-alpha01.

Project:

https://github.com/SUPERCILEX/Robot-Scouter/tree/2e3100276e5fe2cbad8a2cbb36303694e9f46bbd
Setup: ./gradlew setup

yb...@google.com <yb...@google.com> #3Feb 21, 2024 09:16PM

This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.

zh...@google.com <zh...@google.com> #4Feb 21, 2024 11:10PM

Actually, I just checked and it still crashes using 1.1.0-alpha02.

ap...@google.com <ap...@google.com> #5Feb 24, 2024 12:44AM

Could you maybe upload a simpler project with reproduction steps? Or at least provide reproduction steps for the project you linked - Does it crash when using Preference 1.0.0?

This still seems suspiciously similar to

https://issuetracker.google.com/issues/120240628, which can not be reproduced with 1.1.0-alpha02 (following the reproduction steps in the first comment).

ap...@google.com <ap...@google.com> #6Feb 29, 2024 02:12AM

Marked as fixed.

Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in

https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.

If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.

na...@google.com <na...@google.com> #7Mar 6, 2024 07:49PM

I also ran it on a Samsung Galaxy J4+ running Android 8.1.0, and it is the same story. There is no NPE issue using preferences 1.0.0, but using any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02 will cause the NPE.