DataStore CorruptionException not handled in reads after initialization succeeds [289582516]

Fixed

Bug

Status Update

No update yet.

Description

zh...@google.com

created issue #1

Jul 1, 2023 12:16AM

After a few code refactors and bug fixes, DataStoreImpl no longer handles CorruptionException in reads after initialization is successful.

Specifically, readDataOrHandleCorruption is only used in InitDataStore, while readState calls readDataAndUpdateCache which calls attemptRead which simply caches a ReadException if any exception is thrown from the read; updateCollector also calls readDataAndUpdateCache thus doesn't catch CorruptionException.

Create the bug to track the fix.

Comments

zh...@google.com <zh...@google.com> Jul 1, 2023 12:16AM

Reassigned to zh...@google.com.

zh...@google.com <zh...@google.com> Feb 20, 2024 10:06PM

Accepted by zh...@google.com.

zh...@google.com <zh...@google.com> #2Feb 21, 2024 09:01PM

That seems like a big limitation because it means that to get lint checks on them you need to add them to the base but then they are also packaged with the base instead of the dynamic-features. Can we attempt to fix this for 7.1?

yb...@google.com <yb...@google.com> #3Feb 21, 2024 09:16PM

Ok, yes, I can attempt to fix for 7.1.

zh...@google.com <zh...@google.com> #4Feb 21, 2024 11:10PM

thanks!

ap...@google.com <ap...@google.com> #5Feb 24, 2024 12:44AM

ap...@google.com <ap...@google.com> #6Feb 29, 2024 02:12AM

Marked as fixed.

ktzoepubg@gmail.com

na...@google.com <na...@google.com> #7Mar 6, 2024 07:49PM

+1 on the issue (don't see where to star)