DataStore CorruptionException not handled in reads after initialization succeeds [289582516]

Fixed

Bug

Status Update

No update yet.

Description

zh...@google.com

created issue #1

Jul 1, 2023 12:16AM

After a few code refactors and bug fixes, DataStoreImpl no longer handles CorruptionException in reads after initialization is successful.

Specifically, readDataOrHandleCorruption is only used in InitDataStore, while readState calls readDataAndUpdateCache which calls attemptRead which simply caches a ReadException if any exception is thrown from the read; updateCollector also calls readDataAndUpdateCache thus doesn't catch CorruptionException.

Create the bug to track the fix.

Comments

zh...@google.com <zh...@google.com> Jul 1, 2023 12:16AM

Reassigned to zh...@google.com.

zh...@google.com <zh...@google.com> Feb 20, 2024 10:06PM

Accepted by zh...@google.com.

zh...@google.com <zh...@google.com> #2Feb 21, 2024 09:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66494e2d6810347e6a3b41ec3f2665e598f108f0
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 14 00:14:24 2022

Ensure that SavedStateHandle restores upon initial creation

runOnNextRecreation() only runs on the next time
the lifecycle reaches CREATED, not the first time.

By using a LifecycleObserver directly, we ensure that
each Lifecycle move causes a performRestore() to
consistently happen.

Test: existing tests pass, sample app works
BUG: 228865698
Relnote: "Fixed an issue where nesting one `NavHost` within
another `NavHost` in a non-primary bottom navigation tab
would lead to an `IllegalStateException` when using
multiple back stacks."

Change-Id: I11bd5173f035ae1da7922b4142fcedc0f3b54ff6

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/2064518

yb...@google.com <yb...@google.com> #3Feb 21, 2024 09:16PM

Thanks for quick fix! Works well with latest snapshot.

zh...@google.com <zh...@google.com> #4Feb 21, 2024 11:10PM

Thanks for confirming! The fix will be in the next release of Lifecycle (2.5.0-beta01).

ap...@google.com <ap...@google.com> #5Feb 24, 2024 12:44AM

2.4.1 also has same issue

using jetpack compose / bottom navigation with NavHost

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

ap...@google.com <ap...@google.com> #6Feb 29, 2024 02:12AM

Marked as fixed.

I am seeing a high occurance rate with 2.5.0-beta01 as well.

na...@google.com <na...@google.com> #7Mar 6, 2024 07:49PM

Re comment#5 and comment#6 - please file a new bug with a sample project that reproduces your issue. That would help rule out it being a duplicate of this issue where your remember around getBackStackEntry needs to be updated.