Moving up and down in multi-line OutlinedTextField with physical keyboard moves to previous/next input field instead of previous/next line [295666701]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Aug 13, 2023 09:16PM

Jetpack Compose version: 1.5.0
Jetpack Compose component used: androidx.compose.material3:material3:1.2.0-alpha05 / OutlinedTextField
Android Studio Build:Android Studio Giraffe | 2022.3.1
Kotlin version: 1.8.22

When using an OutlinedTextField(...) with multiple lines with a physical keyboard (e.g. with the PC keyboard and the emulator, but also with a bluetooth keyboard on the phone), the up and down arrow keys do not act as expected.

Basically the up/down arrow keys move the focus to the previous/next input field. This is okay for single line input fields and checkboxes. But when it comes to a TextField with multiple lines, the arrow keys should go up/down one line - only when the first line is reached and the up key is pressed, the focus should change. This is not a specific issue of the current version, but has been an issue for multiple versions now.

There is also a topic on Stackoverflow on this:

https://stackoverflow.com/questions/75480217/jetpack-compose-moving-up-and-down-multiple-multi-line-basictextfields-with-phy

The solution only works for BasicTextFields as the OutlinedTextField in Material3 doesn't have the onTextLayout = { } parameter. Anyhow, I believe that moving up/down one line in a multiline TextField should be the defualt behavior without the need of a workaround.

Could you please have a look at this? Thank you!

Comments

kl...@google.com <kl...@google.com> #2Aug 21, 2023 11:12PM

Reassigned to gr...@google.com.

I proposed this which I think it is better than the actual behavior, and could let the developers work with more room to be creative.

https://code.google.com/p/android/issues/detail?id=58318

gr...@google.com <gr...@google.com> #3Aug 22, 2023 06:55PM

The presentation link doesn't work.

Message last modified on Aug 22, 2023 06:55PM

gr...@google.com <gr...@google.com> #4Aug 22, 2023 07:42PM

In Custom Notification Layouts section of the Notification API Guides, it states: "The height available for a custom notification layout depends on the notification view. Normal view layouts are limited to 64 dp, and expanded view layouts are limited to 256 dp". I guess it means the width is 512 dp and the height is 256 dp (if following the 2:1 aspect ratio)?

http://developer.android.com/guide/topics/ui/notifiers/notifications.html#CustomNotification

Message last modified on Aug 22, 2023 07:43PM

pa...@techbee.at <pa...@techbee.at> #5Aug 22, 2023 09:01PM

Here is the presentation:

http://commondatastorage.googleapis.com/io2012/presentations/live%20to%20website/105.pdf

gr...@google.com <gr...@google.com> #6Aug 22, 2023 09:29PM

https://code.google.com/p/android/issues/detail?id=58318http://developer.android.com/reference/android/app/Notification.BigPictureStyle.html#bigPicture(android.graphics.Bitmap)

Message last modified on Aug 22, 2023 09:30PM

pa...@gmail.com <pa...@gmail.com> #7Aug 22, 2023 09:36PM

Any update on this?

gr...@google.com <gr...@google.com> #8May 7, 2024 11:31PM

Reassigned to ha...@google.com.

Thank you for your feedback. We assure you that we are doing our best to address all issues reported. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with the bug report here

https://goo.gl/TbMiIO and reference this bug for context.

ap...@google.com <ap...@google.com> #9May 8, 2024 08:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f22cdff080ac5b0ac8c2efefa3d7daf0b2cd04c8
Author: Halil Ozercan <halilibo@google.com>
Date: Wed May 08 13:26:03 2024

Fix TextField processing of Dpad events

Both the legacy and the new BTF pre-process Dpad directional events to understand whether they are coming from a DPAD device. This is required for TV remotes since directional keys are used to switch focus, instead of carrying the cursor or selection on TVs.

However, the current logic accidentally captures regular hardware keyboards too, causing arrow keys to switch focus instead of manipulate selection.

This fix adopts the Keyboard/DPAD device differentiation logic from the platform by comparing the source of the event directly to the know `InputDevice.SOURCE_KEYBOARD` flag.

Fix: 305087008
Fix: 295666701
Test: gradle :compose:foundation:foundation:cAT
Change-Id: I8af343aa92c208669456bb399c26f9386ec69da5

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldSemanticsTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/textfield/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/TextFieldFocusModifier.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldKeyEventHandler.android.kt

https://android-review.googlesource.com/3079184