Fixed
Status Update
Comments
ya...@google.com <ya...@google.com>
bo...@google.com <bo...@google.com>
ke...@netflix.com <ke...@netflix.com> #2
Feel free to disable the link check as a workaround.
The Gradle equivalent is:
android {
lintOptions {
disable "DialogFragmentCallbacksDetector"
}
}
bo...@google.com <bo...@google.com> #3
Not all of our builds depend on androidx.fragment and if you do not use androidx.fragment and you add this disable flag, lint fails due to non-existant check DialogFragmentCallbacksDetector. If you do not plan on fixing this soon, I can try and see if we can only disable the check if we depend on androidx.fragment.
zh...@google.com <zh...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021
Fix OnCreateDialogIncorrectCallback lint on empty java classes
The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.
RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311
Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456
M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt
https://android-review.googlesource.com/1702325
Branch: androidx-main
commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021
Fix OnCreateDialogIncorrectCallback lint on empty java classes
The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.
RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311
Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456
M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt
sy...@syntezzz.ru <sy...@syntezzz.ru> #5
This has been fixed internally and will be available in the Fragment 1.4.0-alpha01
release.
bo...@google.com <bo...@google.com> #6
I am using 1.4.0-alpha01 of the Fragment Library but I am still getting this error.
bo...@google.com <bo...@google.com> #7
Re #6 - please file a new bug with a sample that reproduces your error.
ja...@google.com <ja...@google.com> #8
Comment has been deleted.
ki...@gmail.com <ki...@gmail.com> #9
Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing
ki...@gmail.com <ki...@gmail.com> #10
تصØÙŠØ Ø£Ø®Ø·Ø§Ø¡ usp
wh...@gmail.com <wh...@gmail.com> #11
Welcome forever welcome
ch...@gmail.com <ch...@gmail.com> #12
ch...@gmail.com <ch...@gmail.com> #13
0947192161
ch...@gmail.com <ch...@gmail.com> #14
CHECK
ch...@gmail.com <ch...@gmail.com> #15
ch...@gmail.com <ch...@gmail.com> #16 Restricted+
Restricted+
Comment has been deleted.
ch...@gmail.com <ch...@gmail.com> #17 Restricted
Restricted
Comment has been deleted.
Description
Android Studio Version: Giraffe | 2022.3.1
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 32.1.14-10330179
HAXM / KVM Version: HVF 13.5.0
Android SDK Tools: 26.1.1
Host Operating System: macOS 13.5
CPU Manufacturer: Other CPU:
64-bit CPU
RAM: 16384 MB
GPU:
Build Fingerprint:
AVD Details: Name: Pixel_C_Tablet_API_33
CPU/ABI: arm64
Path: /Users/tomas/.android/avd/Pixel_C_API_33.avd
Target: google_apis [Google APIs] (API level 33)
Skin: 2560x1800
SD Card: 512 MB
AvdId: Pixel_C_Tablet_API_33
PlayStore.enabled: false
avd.ini.displayname: Pixel C Tablet API 33
avd.ini.encoding: UTF-8
disk.dataPartition.size: 6G
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:b6f369a5174fab4bbf46015b0d842ec6
hw.device.manufacturer: Google
hw.gps: no
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: landscape
hw.keyboard: yes
hw.lcd.density: 320
hw.lcd.height: 1800
hw.lcd.width: 2560
hw.mainKeys: no
hw.ramSize: 1536
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images/android-33/google_apis/arm64-v8a/
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: no
skin.dynamic: yes
skin.path.backup: /Users/tomas/Library/Android/sdk/skins/pixel_c
tag.display: Google APIs
vm.heapSize: 192
Steps to Reproduce Bug:Call PackageManager.hasSystemFeature(PackageManager.FEATURE_SENSOR_HINGE_ANGLE) and this method returns true on Pixel C tablet.
Expected Behavior:
Returns false on Pixel C tablet.
Observed Behavior: