Transitions fail to return to original state after animateToStart() and beginDelayedTransition() [300157785]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 13, 2023 12:31AM

Component used: Transition Version used: 1.5.0-alpha02 Devices/Android versions reproduced on: API 34

If you do a gesture back in Fragments using transitions and cancel the gesture multiple times, after the first cancel, starting the gesture will result in the transition on the exiting view failing to run.

I believe the cause of this is that the beginDelayedTransition() called by with a 0 duration called by Fragment never triggers this onAnimatedEnd() callback in Visibility. That results in the visibility failing to be added removed from the overlay and so the subsequent transitions on the view do not run.

Here are logs synced with the calls from Fragment and Visibility. I would expect there to be an onAnimationEnd reversed=false log before the onTransitionEnd in Visibility.

 V  Animating to start (in Fragment)
 D  onAnimationEnd reversed=true (in Visibility)
 V  Calling beginDelayedTransition (in Fragment)
 D  onTransitionEnd (in Visibility)
 V  On transitionEnd of beginDelayedTransition (in Fragment)

The can be reproduced by patching in aosp/2748867 and doing the following in the navigation-integration app:

Launch App
Press the "Navigate Next" button 2 times to get to the "two" screen
Start a gesture back to the "one" screen and cancel it
Start another gesture back to the "one" screen and the "two" screen will immediately go blank

Comments

mo...@google.com <mo...@google.com> Sep 13, 2023 04:31PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #2Sep 18, 2023 08:29PM

Assigned to jb...@google.com.

The first CL of this effort has been officially submitted in aosp/2926690, adding multiplatform support to lifecycle-common.

va...@google.com <va...@google.com> #3Sep 21, 2023 06:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit e4a654d863af22d2a4f486b90cf29c26c487cffb
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Jan 22 11:49:53 2024

Multiplatform support for lifecycle-runtime

This change introduces multiplatform support for the lifecycle-runtime module by exposing the `LifecycleRegistry` to common, ensuring compatibility with published versions on Android.

BUG: 317249252
Relnote: Added multiplatform support for `lifecycle-runtime`
Test: Run existing and newly added tests
Change-Id: I0c5acfde52bd6c4a3cf7f38193c235915b45d549

M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/MissingClassTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/src/androidMain/java/androidx/lifecycle/LifecycleRegistryOwner.java
A lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/LifecycleRegistry.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ViewTreeLifecycleOwner.android.kt
M lifecycle/lifecycle-runtime/src/androidMain/res/values/ids.xml
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/NoPackageObserver.kt
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/NoPackageTest.kt
M lifecycle/lifecycle-runtime/src/androidUnitTest/kotlin/androidx/lifecycle/LifecycleRegistryTest.java
A lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/LifecycleRegistry.kt
A lifecycle/lifecycle-runtime/src/commonTest/kotlin/androidx/lifecycle/CommonLifecycleRegistryTest.kt
A lifecycle/lifecycle-runtime/src/commonTest/kotlin/androidx/lifecycle/TestObserver.kt
A lifecycle/lifecycle-runtime/src/desktopMain/kotlin/androidx/lifecycle/LifecycleRegistry.desktop.kt
M lifecycle/lifecycle-runtime/src/jvmMain/kotlin/androidx/lifecycle/LifecycleRegistry.jvm.kt
M lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/LifecycleRegistry.native.kt
A lifecycle/lifecycle-runtime/src/nativeTest/kotlin/androidx/lifecycle/NativeLifecycleRegistryTest.kt
M settings.gradle

https://android-review.googlesource.com/2927699

va...@google.com <va...@google.com> #4Sep 21, 2023 07:08PM

The second CL of this effort has been officially submitted in aosp/2927699, adding multiplatform support to lifecycle-runtime.

jb...@google.com <jb...@google.com> #5Sep 26, 2023 08:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 08f40110a0400fa434ed023e763152e6f4aa39af
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Fri Jan 26 17:06:51 2024

Multiplatform support for lifecycle-runtime-ktx

BUG: 317249252
Relnote: Added multiplatform support for `lifecycle-runtime-ktx`
Test: Run existing tests
Change-Id: If445d68e7e85929839ad10347b31b9f11d61c00d

M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime-ktx/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime-ktx/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime-ktx/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M settings.gradle

https://android-review.googlesource.com/2930012

jb...@google.com <jb...@google.com> #6Sep 26, 2023 08:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit d48a756bfcbc4679bbcf641554f75be5458cad04
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Mar 04 22:55:59 2024

Align source sets in lifecycle-runtime with JetBrains fork

- Move shared code into `nonJvmMain` (a common source set for native and web targets)
- Use expect/actual for `WeakReference` and `isMainThread`

Bug: 317249252
Test: N/A
Change-Id: If70f6aa691d231674a7e3234a668e4b8184f2d91

M development/build_log_simplifier/messages.ignore
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/LifecycleRegistry.native.kt
A lifecycle/lifecycle-runtime/src/nativeMain/kotlin/androidx/lifecycle/WeakReference.native.kt
A lifecycle/lifecycle-runtime/src/nonJvmMain/kotlin/androidx/lifecycle/LifecycleRegistry.nonJvm.kt
A lifecycle/lifecycle-runtime/src/nonJvmMain/kotlin/androidx/lifecycle/WeakReference.nonJvm.kt

https://android-review.googlesource.com/2986215

ap...@google.com <ap...@google.com> #7Sep 26, 2023 08:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1b02695fac60c198985910d0a4658a3f53027f35
Author: Ivan Matkov <ivan.matkov@jetbrains.com>
Date: Mon Mar 04 22:08:16 2024

Align source sets in lifecycle-common with JetBrains fork

- Move shared code into `nonJvmMain` (a common source set for native and web targets)

Bug: 317249252
Test: N/A
Change-Id: If7e05abc26e53d93f1b853941687602093576cc5

M lifecycle/lifecycle-common/build.gradle
M lifecycle/lifecycle-common/src/nonJvmMain/kotlin/androidx/lifecycle/Lifecycle.nonJvm.kt
M lifecycle/lifecycle-common/src/nonJvmMain/kotlin/androidx/lifecycle/Lifecycling.nonJvm.kt

https://android-review.googlesource.com/2986214

jb...@google.com <jb...@google.com> #8Oct 25, 2023 12:42AM

Reassigned to mo...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-common:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iossimulatorarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-iosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-jvm:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-linuxx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-macosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-common-macosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-android:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-desktop:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iossimulatorarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-iosx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-linuxx64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-macosarm64:2.8.0-alpha03
androidx.lifecycle:lifecycle-runtime-macosx64:2.8.0-alpha03

AnimateToStartAlpha03.zip

108 KB

Download

mo...@google.com <mo...@google.com> Nov 8, 2023 10:21PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #9Nov 9, 2023 12:14AM

The API has changed since that project was created in a way that makes the API more robust. I'm hoping that has fixed this...

mo...@google.com <mo...@google.com> #10Nov 9, 2023 06:18PM

There appears to be a problem with the order of operations. I'm going to look into fixing that.

ap...@google.com <ap...@google.com> #11Nov 10, 2023 11:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e57dd5f9ac6cbb8cf83b221e2d5b3fbd3e88ce6b
Author: George Mount <mount@google.com>
Date: Thu Nov 09 14:33:53 2023

Fix animateToStart with Slide.

Fixes: 300157785

Slide was not repositioning the View to its proper
translation after animating it to the start position.
This fixes that so that it is moved.

Test: new test
Change-Id: I698f4dbcef46304f9aa545847d205f7b70c80d63

M transition/transition/src/androidTest/java/androidx/transition/SlideEdgeTest.java
M transition/transition/src/androidTest/java/androidx/transition/TranslationAnimationCreatorTest.java
M transition/transition/src/main/java/androidx/transition/TranslationAnimationCreator.java

https://android-review.googlesource.com/2824840

pr...@google.com <pr...@google.com> #12Nov 29, 2023 09:39PM