Transitions fail to return to original state after animateToStart() and beginDelayedTransition() [300157785]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 13, 2023 12:31AM

Component used: Transition Version used: 1.5.0-alpha02 Devices/Android versions reproduced on: API 34

If you do a gesture back in Fragments using transitions and cancel the gesture multiple times, after the first cancel, starting the gesture will result in the transition on the exiting view failing to run.

I believe the cause of this is that the beginDelayedTransition() called by with a 0 duration called by Fragment never triggers this onAnimatedEnd() callback in Visibility. That results in the visibility failing to be added removed from the overlay and so the subsequent transitions on the view do not run.

Here are logs synced with the calls from Fragment and Visibility. I would expect there to be an onAnimationEnd reversed=false log before the onTransitionEnd in Visibility.

 V  Animating to start (in Fragment)
 D  onAnimationEnd reversed=true (in Visibility)
 V  Calling beginDelayedTransition (in Fragment)
 D  onTransitionEnd (in Visibility)
 V  On transitionEnd of beginDelayedTransition (in Fragment)

The can be reproduced by patching in aosp/2748867 and doing the following in the navigation-integration app:

Launch App
Press the "Navigate Next" button 2 times to get to the "two" screen
Start a gesture back to the "one" screen and cancel it
Start another gesture back to the "one" screen and the "two" screen will immediately go blank

Comments

mo...@google.com <mo...@google.com> Sep 13, 2023 04:31PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #2Sep 18, 2023 08:29PM

Assigned to jb...@google.com.

The removal of the nested graphs and using popUpTo the given fragment appears to prevent the crash from happening in 1.0.0-alpha11.

va...@google.com <va...@google.com> #3Sep 21, 2023 06:57PM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit 63bc1ff1fe7c348138295ee7efb8cdc2999622c0
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:18:53 2019

Update prebuilts for Navigation 1.0.0-beta01

Include fix for

b/123803044

Test: ./gradlew bOS
Change-Id: Icb2a50975541a7bd3327054c72a591c7689c9741

M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.sha1

https://android-review.googlesource.com/892878

https://goto.google.com/android-sha1/63bc1ff1fe7c348138295ee7efb8cdc2999622c0

va...@google.com <va...@google.com> #4Sep 21, 2023 07:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019

Return true when popping from FragmentNavigator

Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().

This ensures that the FragmentManager state and the
NavController states don't get out of sync.

Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/892996

https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec

jb...@google.com <jb...@google.com> #5Sep 26, 2023 08:12PM

This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.

jb...@google.com <jb...@google.com> #6Sep 26, 2023 08:46PM

Nice job! A quick response!

ap...@google.com <ap...@google.com> #7Sep 26, 2023 08:56PM

I still get this error using the lastest 1.0.0 release :

implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"

I'm using nested graphs.

jb...@google.com <jb...@google.com> #8Oct 25, 2023 12:42AM

Reassigned to mo...@google.com.

Re #7 - please file a new bug with a sample app that reproduces your issue.

AnimateToStartAlpha03.zip

108 KB

Download

mo...@google.com <mo...@google.com> Nov 8, 2023 10:21PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #9Nov 9, 2023 12:14AM

Done.

https://issuetracker.google.com/131733658

mo...@google.com <mo...@google.com> #10Nov 9, 2023 06:18PM

There appears to be a problem with the order of operations. I'm going to look into fixing that.

ap...@google.com <ap...@google.com> #11Nov 10, 2023 11:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e57dd5f9ac6cbb8cf83b221e2d5b3fbd3e88ce6b
Author: George Mount <mount@google.com>
Date: Thu Nov 09 14:33:53 2023

Fix animateToStart with Slide.

Fixes: 300157785

Slide was not repositioning the View to its proper
translation after animating it to the start position.
This fixes that so that it is moved.

Test: new test
Change-Id: I698f4dbcef46304f9aa545847d205f7b70c80d63

M transition/transition/src/androidTest/java/androidx/transition/SlideEdgeTest.java
M transition/transition/src/androidTest/java/androidx/transition/TranslationAnimationCreatorTest.java
M transition/transition/src/main/java/androidx/transition/TranslationAnimationCreator.java

https://android-review.googlesource.com/2824840

pr...@google.com <pr...@google.com> #12Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.transition:transition:1.5.0-alpha05