Status Update
No update yet.
Comments
ma...@mark43.com
el...@google.com
When I was trying out integrating this with Now in Android, I ran into this issue since Now in Android currently doesn't inherit from AppCompatActivity and doesn't call AppCompatDelegate.setDefaultNightMode, so maybe the solution is instead to inherit from AppCompatActivity instead of just ComponentActivity to update the underlying configuration.
el...@google.com
ap...@google.com
I just tested it with ComponentActivity. It's working fine for me. The scrim for 3-button nav and the icons are properly changed on light/dark mode switch. The extension function detect light/dark mode from resources.configuration.uiMode which is commonly used by the platform, AppCompat, and Compose, so I don't know why it doesn't work. Can I take a look at what you tried in Now in Android.
pr...@google.com
The theme switcher based on the user's preference within the app is handled separately from Configuration.uiMode and isn't updating the configuration directly, so I was attempting to call enableEdgeToEdge and manually specifying the dark and light themes.
The two options I see:
- Allow a different way of specifying for
enableEdgeToEdgewhether the app is effectively in dark mode or light mode instead of that being based just onConfiguration.uiMode(this issue) - Switch Now in Android to use
AppCompatActivityandAppCompatDelegate.setDefaultNightModeso that theConfiguration.uiModeis updated based on the user's preference
Description
Version used:"2.6.0-rc01"
Devices/Android versions reproduced on: Not related
Kotlin implementation of DAO for @RawQuery function implementation with return type Double is initailised with 0 instead of 0.0 on null check.
@Entity
class Test(@PrimaryKey val d: Double, val l: Long) {
@Dao
interface TestDao {
@RawQuery
fun getLocation(query: SupportSQLiteQuery): Test
}
}
For this setup Room generates the following implementation:
private fun __entityCursorConverter_comTest(cursor: Cursor): Test {
val _entity: Test
val _cursorIndexOfD: Int = getColumnIndex(cursor, "d")
val _cursorIndexOfL: Int = getColumnIndex(cursor, "l")
val _tmpD: Double
if (_cursorIndexOfD == -1) {
_tmpD = 0 //Error: The integer literal does not conform to the expected type Double
} else {
_tmpD = cursor.getDouble(_cursorIndexOfD)
}
val _tmpL: Long
if (_cursorIndexOfL == -1) {
_tmpL = 0
} else {
_tmpL = cursor.getLong(_cursorIndexOfL)
}
_entity = Test(_tmpD,_tmpL)
return _entity
}