Status Update
Comments
as...@google.com <as...@google.com>
ti...@google.com <ti...@google.com> #2
I wasn't able to reproduce the crash using the snippet in 1.6.0-alpha08
.
Could you share more details on the steps to reproduce the crash? Alternatively, a recording of the swiping that leads to a crash could work too. Thanks!
ma...@mario-noll.de <ma...@mario-noll.de> #3
Revisiting a page that has already been displayed usually triggers the crash. I attached a screen recording, from an API 28 emulator, which uses a debug build from the linked repository above.
ti...@google.com <ti...@google.com> #4
Thanks for the repro repository.
Update: I'm able to repro with the repository linked in 1.6.0-alpha08
but not on tip of tree.
co...@protonmail.com <co...@protonmail.com> #5
Is there anything we can do to hotfix at the moment @ti...@google.com? I'm currently on alpha06. Do we just have to wait another week, or is there possibly a patch I can put in today?
gl...@gmail.com <gl...@gmail.com> #6
One week, I think that you are a very optimistic person.
This bug has to have a higher priority and I think that's a duplicate of:
ti...@google.com <ti...@google.com> #7
Re
co...@protonmail.com <co...@protonmail.com> #8
ok, i dont have a repro, but i do have a pretty simple compose app that has this one wild crash in firebase. i can try to get you further stacktraces etc, or i can just update to alpha08 and see if that fixes it. let me try to push an update now and ill see over the next few days if the crash in firebase disapears
ma...@mario-noll.de <ma...@mario-noll.de> #9
Update: I'm able to repro with the repository linked in
, using 1.6.0-alpha08 but not on tip of tree. comment #1
Just to confirm, the issue can no longer be reproduced with 1.6.0-beta01
co...@protonmail.com <co...@protonmail.com> #10
Seems like some people can still repro. I'll try to ship 1.6.0-beta01 today and see what happens in prod.
mx...@gmail.com <mx...@gmail.com> #11
I'm able to consistently reproduce this in my app with 1.6.0-beta02
but not with 1.6.0-beta03
.
By trying several snapshot builds, I found that it's not reproducible after
Since that CL doesn't actually fix the issue if I understand correctly, I think it might help if I share the repro, right?
If so, I'll try to come up with a smaller repro.
mx...@gmail.com <mx...@gmail.com> #12
I realized that adding a LookaheadScope
is enough to reproduce the crash, even with 1.6.0-beta03.
So here's the repro. The app will automatically scroll the lazy grid randomly and crash should happen in no more than one minute.
ti...@google.com <ti...@google.com> #13
Thanks for the repro. It'll be helpful for our investigation.
ap...@google.com <ap...@google.com> #14
Branch: androidx-main
commit 97c0c78e1739d83d92d9ca994b22d016f86e6e9c
Author: Doris Liu <tianliu@google.com>
Date: Mon Jan 08 17:53:17 2024
Fix incorrect invaliations when placement is toggled
This CL fixes the invalidation when a node becomes placed
from a not-placed state. This can happen when the parent node
selectively places children depending on the some predefined
logic such as viewport size.
Fixes: 306193893
Test: new tests added
Change-Id: I5b2039b7a0bc5b0e6f19b4ce60c989ef8a440788
A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/TogglePlacementInLookaheadScope.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeLayoutDelegate.kt
na...@google.com <na...@google.com> #15
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.6.0
androidx.compose.ui:ui-android:1.6.0
androidx.compose.ui:ui-desktop:1.6.0
Description
Updating
androidx.compose.material:material
from1.5.4
to1.6.0-alpha08
introduced the following crash, when scrolling between pages of aHorizontalPager
:The crash happens when swiping pages of ahttps://github.com/MarioNoll/compose_ui_crash_reproducer ):
HorizontalPager
where one of the pages uses aConstraintLayout
and compose navigation is used. When removing either theNavHost
or theConstraintLayout
the crash does not appear anymore. Here is a small reproducer (also available here