enableEdgeToEdge should consider display cutouts [311173461]

Fixed

Feature Request

Status Update

No update yet.

Description

jo...@google.com

created issue #1

Nov 15, 2023 03:16PM

Component used: Activity

Version used: 1.8.0

Devices/Android versions reproduced on: Pixel 7 Pro API 34 emulator

enableEdgeToEdge by default does not add drawing behind the display cutout in landscape mode (see default.png attachment), therefore not really giving an edge-to-edge experience.

This could easily be added with this snippet:

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
            findWindow()?.attributes?.layoutInDisplayCutoutMode =
                LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
        }

Comments

jo...@google.com <jo...@google.com> Nov 15, 2023 03:21PM

cutout-default.png

1.6 MB

View

Download

cutout-shortEdge.png

3.9 MB

View

Download

jb...@google.com <jb...@google.com> Nov 15, 2023 03:42PM

Assigned to ya...@google.com.

he...@gmail.com <he...@gmail.com> #2Nov 24, 2023 07:19AM

This is a hard one. We can't easily read native crashes from that Motorola device since their system image is not public. I assume you can't reproduce this either, but if possible can you try using WorkManager 2.0.0 or 1.0.1-rc01? This would help track down the possible changes that might have introduced this issue. Thanks!

ap...@google.com <ap...@google.com> #3Dec 11, 2023 02:33AM

We actually did reproduce it, the current store version of Pocket Casts has WorkManager 2.0.0 and this bug if you want to try and test something. I will try 1.0.1-rc01 and report back.

ya...@google.com <ya...@google.com> Dec 11, 2023 02:34AM

Marked as fixed.

il...@google.com <il...@google.com> #4Dec 11, 2023 04:38PM

Is there a difference between 1.0.1 and 2.0.1? We tried 2.0.1 and it was crashing, if there is a difference I can try 1.0.1 but I thought they were the same?

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

Can you also describe how you trigger the bug and which devices manifest the problem? Is it just running the app? Is it doing something specific?