enableEdgeToEdge should consider display cutouts [311173461]

Fixed

Feature Request

Status Update

No update yet.

Description

jo...@google.com

created issue #1

Nov 15, 2023 03:16PM

Component used: Activity

Version used: 1.8.0

Devices/Android versions reproduced on: Pixel 7 Pro API 34 emulator

enableEdgeToEdge by default does not add drawing behind the display cutout in landscape mode (see default.png attachment), therefore not really giving an edge-to-edge experience.

This could easily be added with this snippet:

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
            findWindow()?.attributes?.layoutInDisplayCutoutMode =
                LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
        }

Comments

jo...@google.com <jo...@google.com> Nov 15, 2023 03:21PM

cutout-default.png

1.6 MB

View

Download

cutout-shortEdge.png

3.9 MB

View

Download

jb...@google.com <jb...@google.com> Nov 15, 2023 03:42PM

Assigned to ya...@google.com.

he...@gmail.com <he...@gmail.com> #2Nov 24, 2023 07:19AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ap...@google.com <ap...@google.com> #3Dec 11, 2023 02:33AM

yea i'll take it.

ya...@google.com <ya...@google.com> Dec 11, 2023 02:34AM

Marked as fixed.

il...@google.com <il...@google.com> #4Dec 11, 2023 04:38PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}