enableEdgeToEdge should consider display cutouts [311173461]

Fixed

Feature Request

Status Update

No update yet.

Description

jo...@google.com

created issue #1

Nov 15, 2023 03:16PM

Component used: Activity

Version used: 1.8.0

Devices/Android versions reproduced on: Pixel 7 Pro API 34 emulator

enableEdgeToEdge by default does not add drawing behind the display cutout in landscape mode (see default.png attachment), therefore not really giving an edge-to-edge experience.

This could easily be added with this snippet:

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
            findWindow()?.attributes?.layoutInDisplayCutoutMode =
                LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
        }

Comments

jo...@google.com <jo...@google.com> Nov 15, 2023 03:21PM

cutout-default.png

1.6 MB

View

Download

cutout-shortEdge.png

3.9 MB

View

Download

jb...@google.com <jb...@google.com> Nov 15, 2023 03:42PM

Assigned to ya...@google.com.

he...@gmail.com <he...@gmail.com> #2Nov 24, 2023 07:19AM

After creating the issue I've noticed that I mixed up a few terms, sorry about that. JobService should be JobScheduler. When referring to jobs in the description, those are classes extending Worker.

ap...@google.com <ap...@google.com> #3Dec 11, 2023 02:33AM

We have a large set of users seeing this same issue... I can confirm that it seems to only effect users using Android OS 4.4 - 5.1. We are also using WorkManager 2.0.0

ya...@google.com <ya...@google.com> Dec 11, 2023 02:34AM

Marked as fixed.

il...@google.com <il...@google.com> #4Dec 11, 2023 04:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 098c163581a360c32baa6e4c215227f0efd10889
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Mar 25 14:05:34 2019

Reset WorkConstraintsTracker when cleaning up in DelayMetCommandHandler.

* DelayMetCommandHandler would previously not cleanup correctly and WorkConstraintsTracker
would trigger callbacks without going through the SystemAlarmDispatcher lifecycle
of processing a command.

Fixes:

b/129226383

Test: Added a unit test.
Change-Id: Id2aaf0cce7c4a1a4526a25a211f3fe0551dbe557

M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java

https://android-review.googlesource.com/933140

https://goto.google.com/android-sha1/098c163581a360c32baa6e4c215227f0efd10889

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

Great to see such a quick fix. Do you have any estimate when a new version that includes this change will be released?