enableEdgeToEdge should consider display cutouts [311173461]

Fixed

Feature Request

Status Update

No update yet.

Description

jo...@google.com

created issue #1

Nov 15, 2023 03:16PM

Component used: Activity

Version used: 1.8.0

Devices/Android versions reproduced on: Pixel 7 Pro API 34 emulator

enableEdgeToEdge by default does not add drawing behind the display cutout in landscape mode (see default.png attachment), therefore not really giving an edge-to-edge experience.

This could easily be added with this snippet:

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
            findWindow()?.attributes?.layoutInDisplayCutoutMode =
                LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
        }

Comments

jo...@google.com <jo...@google.com> Nov 15, 2023 03:21PM

cutout-default.png

1.6 MB

View

Download

cutout-shortEdge.png

3.9 MB

View

Download

jb...@google.com <jb...@google.com> Nov 15, 2023 03:42PM

Assigned to ya...@google.com.

he...@gmail.com <he...@gmail.com> #2Nov 24, 2023 07:19AM

Further testing shows 11.0.0 works in this setup and 11.2.0 is the first version this appears.

ap...@google.com <ap...@google.com> #3Dec 11, 2023 02:33AM

This is expected. Both libraries have a java resource called 'protobuf.meta', which either the library authors need to stop shipping or the build author needs to pick one. See

https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.PackagingOptions.html

However, if both libraries actually depend on that java resource you are in trouble.

ya...@google.com <ya...@google.com> Dec 11, 2023 02:34AM

Marked as fixed.

il...@google.com <il...@google.com> #4Dec 11, 2023 04:38PM

I can confirm that specifying exclude or pick-first on protobuf.meta results in a successful build and no *immediate* problems. However, the contents of these two files are completely different and without understanding the purpose of these files (I assume related to protocol buffer data structure) it feels very treacherous to remove them.

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

Stephan, do you know what that file does and what changed that meant that it has started being bundled as a java resource in the testing support library?