Workaround for library profiles in pre agp 8.3.0-alpha15 [313992099]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Nov 29, 2023 10:31PM

Due to b/309858620 we need a workaround for library profiles in pre agp 8.3.0-alpha15.

When not meeting min agp version, for libraries we can only always merge the profile for all build type and flavors and output it in src/main/baseline-prof.txt.

Comments

ma...@google.com <ma...@google.com> Nov 29, 2023 10:31PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Dec 15, 2023 07:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d0a10be065a3a629e3835f28d35804c91d8d2e4d
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1427352

ap...@google.com <ap...@google.com> #3Dec 15, 2023 07:53PM

We've updated the error message to make it more clear what destination you're currently on - this will help you determine if your call to setGraph() hasn't happened yet (you have a null current destination) or if you've popped to another destination unexpectedly.

ma...@google.com <ma...@google.com> Dec 20, 2023 06:13PM

Assigned to ch...@google.com.

ch...@google.com <ch...@google.com> #4Dec 21, 2023 12:29AM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 6ada6bd039f4a28d2760f4912093abc60ab54d84
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436733

ma...@google.com <ma...@google.com> Dec 21, 2023 05:28PM

Marked as fixed.

pr...@google.com <pr...@google.com> #5Feb 21, 2024 07:33PM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit e5780347bfba28e4a500bd964d273c282c12dceb
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 16:10:06 2020

Mention the current destination in getBackStackEntry errors

Improve the debugging experience for "No destination
with ID..." errors in getBackStackEntry() by mentioning
exactly destination the NavController is on. This would
allow developers to know if they have called popBackStack()
to a destination they don't expect to be at or if
they have not called setGraph() at all (where the
current destination would be null).

Test: existing tests pass
BUG: 168311416
Change-Id: Ia96b6732d7caadbddf31b7f35a1a419407ff6e25
(cherry picked from commit d0a10be065a3a629e3835f28d35804c91d8d2e4d)

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/1436737