Workaround for library profiles in pre agp 8.3.0-alpha15 [313992099]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Nov 29, 2023 10:31PM

Due to b/309858620 we need a workaround for library profiles in pre agp 8.3.0-alpha15.

When not meeting min agp version, for libraries we can only always merge the profile for all build type and flavors and output it in src/main/baseline-prof.txt.

Comments

ma...@google.com <ma...@google.com> Nov 29, 2023 10:31PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Dec 15, 2023 07:53PM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

ap...@google.com <ap...@google.com> #3Dec 15, 2023 07:53PM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

ma...@google.com <ma...@google.com> Dec 20, 2023 06:13PM

Assigned to ch...@google.com.

ch...@google.com <ch...@google.com> #4Dec 21, 2023 12:29AM

Reassigned to ma...@google.com.

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

ma...@google.com <ma...@google.com> Dec 21, 2023 05:28PM

Marked as fixed.

pr...@google.com <pr...@google.com> #5Feb 21, 2024 07:33PM

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!