Status Update
No update yet.
Comments
vs...@google.com
rk...@google.com
wd...@google.com
ru...@gmail.com
Branch: androidx-master-dev
commit b55fe68edc02b253b908a1c7c2e98350ba67afe4
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 12 14:21:57 2020
Ignore Animations/Animator when Transitions run
For a given Fragment, a single owner for its
transition from visible to non-visible is needed
to avoid conflicts as different systems try to
influence the same set of properties.
This has two consequences:
- Animations (which work at the parent container level)
will interfere if there are *any* Transitions run.
- Animators will interfere if there are any Transitions
run on that specific Fragment.
By tracking which Transitions were started and using
that information to selectively ignore conflicting
Animations/Animators, we can avoid visual artifacts.
Test: updated tests pass
BUG: 149569323
Change-Id: I9e5169ffd36853c3dfbd7f217837a74674a9508d
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
ru...@gmail.com
There are two parallel systems in Android - the Animation system and the Animator system (which the Transition system is built on top of). With this change and Fragment 1.3.0-alpha08, no Animation will run if there are any Transitions kicked off at the same time and no Animator will run on Fragments that have Transitions directly associated with them (either via an enter/exit transition or as part of a shared element transition).
ru...@gmail.com
Branch: androidx-master-dev
commit fa55358f7f2870bf05ef5cce12d2b4e2d86732aa
Author: Ian Lake <ilake@google.com>
Date: Mon Sep 14 11:30:52 2020
Ignore Animations when Animators run
As a continuation of the work in
we now prioritize running Animators over running
Animations. This avoids cases where both are
running simultaneously.
As Animations and Animators are now properly
decoupled, we can use animator.cancel() when
our CancelationSignal is triggered instead of
using clearAnimation().
Test: all tests pass, updated FragmentAnimatorTest passes
BUG: 167579557
Change-Id: I7b3f5c1cc1355e02ff770838cb485d659dfb1619
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimatorTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
ru...@gmail.com
Just a note - we recompiled 33.1.24 by simply taking out the ifdefs in IpAddress::toString() and by turning on gfxstream and got no linker issues (according to the comment that was why the ifdef guards were there in the first place) and proxy seems to work.
ru...@gmail.com
If there is no progress on this can anyone from the google team advise how to properly build with gfxstream on? What we did was take 33.1.24 and remove the ifdef in the snipper above and then turn on the gfxstream cmake option, but it seems that that causes a weird build - we get ""Your GPU drivers may have a bug" which as far as i can see should not be there since the getGpuInfoListNative method in hardware/google/gfxstream/gl-host-common/opengl/NativeGpuInfo_linux.cpp doesn't even scan for gpus? So we are clearly somehow building it wrong, any advice would be appreciated as long as we cannot use the stock emulator with the proxy feature working.
al...@gmail.com
kc...@gmail.com
Hello, this is impacting us greatly. Please fix this asap. Thank you.
wd...@google.com
ru...@gmail.com
Since the review link is not public, could you confirm that removing the ifdef is a legitimate fix (and the random rare crashes we we are seeing with removing the ifdef and building with gfxstream is something else) or are there other changes that need to be done?
wd...@google.com
RE#10 Thank you for pointing that out. Removing the ifdef is a legitmate fix. The random crash is interesting but I doubt it has to with removing ifdef. Previously the ifdef guard was there probably because we used to have migw windows target but I don't think it's there anymore.
My fix is landed in
bo...@google.com
bo...@google.com
we need a new release for 34.1.x
Description
DESCRIBE THE ISSUE IN DETAIL: The
-http-proxycommand line parameter is not parsed correctly no matter what format I use - it uses an empty string as a hostname/ip and fails to connect. The port is parsed correctly. Formats I tried:STEPS TO REPRODUCE:
emulator.exe -avd Pixel_3a_API_34_extension_level_7_x86_64 -http-proxy 127.0.0.1:8888 -verbose -debug-proxyNote: I tried to create the issue in "Android Studio > Emulator" component but got "You do not have permission to create issues in this component."